Added support for variable font DPI (range 64-512) in user session. #229

Merged
MicheleC merged 1 commits from feat/variable-font-dpi into master 3 years ago
Owner

As per title. In TCC -> Appearance & Themes -> Fonts page there is now a spinbox control to set the font DPI for the user session in the range 64-512.
To try minimizing changes, I kept the existing combobox to enable/disable the settings.
Attached is what it looks like + KCalc open at 3 different DPI settings (80, 120, 160).

Please test and feedback before we merge.

As per title. In TCC -> Appearance & Themes -> Fonts page there is now a spinbox control to set the font DPI for the user session in the range 64-512. To try minimizing changes, I kept the existing combobox to enable/disable the settings. Attached is what it looks like + KCalc open at 3 different DPI settings (80, 120, 160). Please test and feedback before we merge.
MicheleC added this to the R14.0.11 release milestone 3 years ago
Poster
Owner

The settings in starttde seems to be unnecessary. Even without that part of the code, the DPI gets set somewhere else at the right value.
Should we remove that part of code? Or leave it just in case?

The settings in starttde seems to be unnecessary. Even without that part of the code, the DPI gets set somewhere else at the right value. Should we remove that part of code? Or leave it just in case?
Owner

The settings in starttde seems to be unnecessary. Even without that part of the code, the DPI gets set somewhere else at the right value.
Should we remove that part of code? Or leave it just in case?

I assume that the DPI setting in starttde gives good assurance that the selected DPI is active before any application is active.

> The settings in starttde seems to be unnecessary. Even without that part of the code, the DPI gets set somewhere else at the right value. > Should we remove that part of code? Or leave it just in case? I assume that the DPI setting in `starttde` gives good assurance that the selected DPI is active before any application is active.
Poster
Owner

I now remember some previous tests, and I think the code in starttde is used by twin, while the settings is then updated again and used by the apps. So definitely worth keeping the code there.

I now remember some previous tests, and I think the code in starttde is used by twin, while the settings is then updated again and used by the apps. So definitely worth keeping the code there.
MicheleC force-pushed feat/variable-font-dpi from 1ce13e975d to 2a361c52e1 3 years ago
MicheleC changed title from Added support for variable font DPI (range 64-256) in user session. to WIP: Added support for variable font DPI (range 64-512) in user session. 3 years ago
Poster
Owner

Although functional, I have marked this WIP till I complete one remaining step, hopefully tomorrow.

Although functional, I have marked this WIP till I complete one remaining step, hopefully tomorrow.
MicheleC force-pushed feat/variable-font-dpi from 2a361c52e1 to 6c61561188 3 years ago
MicheleC changed title from WIP: Added support for variable font DPI (range 64-512) in user session. to Added support for variable font DPI (range 64-512) in user session. 3 years ago
Poster
Owner

This is now good for review.

This is now good for review.
MicheleC force-pushed feat/variable-font-dpi from 6c61561188 to e8d8664504 3 years ago
SlavekB approved these changes 3 years ago
SlavekB left a comment
Owner

Great, now it works as it was intended.

Great, now it works as it was intended.
MicheleC merged commit e8d8664504 into master 3 years ago
MicheleC deleted branch feat/variable-font-dpi 3 years ago
Poster
Owner

Thanks for testing Slavek!

Thanks for testing Slavek!

Reviewers

SlavekB approved these changes 3 years ago
The pull request has been merged as e8d8664504.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#229
Loading…
There is no content yet.