TDE
/
tdebase
9
4
Fork 1
Code Issues 116 Pull Requests 10 Releases Wiki Activity
Labels Milestones

kcontrol/tde-menu: Items for adjust text now depends on Display text in menu button checkbox. #230

Merged
SlavekB merged 2 commits from feat/kcontrol-kicker-menu-text into master 3 years ago
Conversation 4 Commits 2 Files Changed 1
SlavekB commented 3 years ago
Owner

Items for setting text and font for the text shown on the TDE menu button should be dependent on checkbox Display text in menu button. What is your opinion?

Items for setting text and font for the text shown on the TDE menu button should be dependent on checkbox _Display text in menu button_. What is your opinion?
MicheleC requested changes 3 years ago
MicheleC left a comment
Owner

The idea is good. Small thing to adjust.

The idea is good. Small thing to adjust.
kcontrol/kicker/menutab.ui Outdated
<receiver>searchShortcutLabel</receiver>
<slot>setEnabled(bool)</slot>
</connection>
</connections>
MicheleC commented 3 years ago
Owner

Am I wrong or this was already done by Philippe in another commit? Should not be part of this PR.

Am I wrong or this was already done by Philippe in another commit? Should not be part of this PR.
SlavekB commented 3 years ago
Poster
Owner

I can do it as a separate commit because it complements the part that did Philippe – this part adds connection also to the appropriate label Search shortcut:

I can do it as a separate commit because it complements the part that did Philippe – this part adds connection also to the appropriate label _Search shortcut:_
MicheleC commented 3 years ago
Owner

Ah, I see, understood. It's the label, not the button. Either adjust the commit msg or make separate commit sounds good to me.

Ah, I see, understood. It's the label, not the button. Either adjust the commit msg or make separate commit sounds good to me.
SlavekB commented 3 years ago
Poster
Owner

Divided into two commits.

Divided into two commits.
MicheleC marked this conversation as resolved
MicheleC commented 3 years ago
Owner

By the way, the text diplay has issues if Kicker is vertical (for example on the left side of the screen): the text is not visible.
Also if the text is too big, the text seems partially cut off on normal kicker placement (horizontal at the bottom)

By the way, the text diplay has issues if Kicker is vertical (for example on the left side of the screen): the text is not visible. Also if the text is too big, the text seems partially cut off on normal kicker placement (horizontal at the bottom)
SlavekB force-pushed feat/kcontrol-kicker-menu-text from de65777493 to 0f139004ca 3 years ago
MicheleC approved these changes 3 years ago
MicheleC left a comment
Owner

Looks good now

Looks good now
MicheleC commented 3 years ago
Owner

Just think out aloud, I wonder if it is possible to have multiple receivers for the same sender in the .ui file. In that case the code could be more compact. But I have no idea if that functionality is supported.

Just think out aloud, I wonder if it is possible to have multiple receivers for the same sender in the .ui file. In that case the code could be more compact. But I have no idea if that functionality is supported.
SlavekB commented 3 years ago
Poster
Owner

Just think out aloud, I wonder if it is possible to have multiple receivers for the same sender in the .ui file. In that case the code could be more compact. But I have no idea if that functionality is supported.

I believe it is not possible because there is a combination of the receiver + slot, which in the case of placing more receivers could not ensure the use of the correct slots => dependency on the order in the XML code is not a suitable method.

> Just think out aloud, I wonder if it is possible to have multiple receivers for the same sender in the .ui file. In that case the code could be more compact. But I have no idea if that functionality is supported. I believe it is not possible because there is a combination of the receiver + slot, which in the case of placing more receivers could not ensure the use of the correct slots => dependency on the order in the XML code is not a suitable method.
MicheleC commented 3 years ago
Owner

Just think out aloud, I wonder if it is possible to have multiple receivers for the same sender in the .ui file. In that case the code could be more compact. But I have no idea if that functionality is supported.

I believe it is not possible because there is a combination of the receiver + slot, which in the case of placing more receivers could not ensure the use of the correct slots => dependency on the order in the XML code is not a suitable method.

That's probably true, we would have to check the code but not an important point. It was just curiosity.

> > Just think out aloud, I wonder if it is possible to have multiple receivers for the same sender in the .ui file. In that case the code could be more compact. But I have no idea if that functionality is supported. > > I believe it is not possible because there is a combination of the receiver + slot, which in the case of placing more receivers could not ensure the use of the correct slots => dependency on the order in the XML code is not a suitable method. That's probably true, we would have to check the code but not an important point. It was just curiosity.
SlavekB merged commit 0f139004ca into master 3 years ago
SlavekB deleted branch feat/kcontrol-kicker-menu-text 3 years ago
SlavekB added this to the R14.0.11 release milestone 3 years ago

Reviewers

MicheleC approved these changes 3 years ago
The pull request has been merged as 0f139004ca.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.11 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#230
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/kcontrol-kicker-menu-text'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes