starttde: Add dynamic determination of default value for forceFontDPIEnable #231

Merged
SlavekB merged 1 commits from issue/229/starttde-default-forceFontDPIEnable into master 3 years ago
Owner

depending on the current value of forceFontDPI. This solves the automatic transition of configuration after adding support for variable font DPI.

depending on the current value of forceFontDPI. This solves the automatic transition of configuration after adding support for variable font DPI.
SlavekB added this to the R14.0.11 release milestone 3 years ago
MicheleC requested changes 3 years ago
MicheleC left a comment
Owner

It looks good and it's a nice completion on the previous work.
I would rework one line of the script though

It looks good and it's a nice completion on the previous work. I would rework one line of the script though
starttde Outdated
# Get current font DPI configuration
CUR_ForceFontDPI="`$TDEDIR/bin/kreadconfig --file kcmfonts --group General --key forceFontDPI --default 0`"
[ $CUR_ForceFontDPI -gt 0 ] && CUR_ForceFontDPIEnable=true || CUR_ForceFontDPIEnable=false
Owner

How about changing line 369 into this? Easier to read, takes away any need to think about priority of && and || and order of execution

CUR_ForceFontDPIEnable=false
[ $CUR_ForceFontDPI -gt 0 ] && CUR_ForceFontDPIEnable=true
How about changing line 369 into this? Easier to read, takes away any need to think about priority of && and || and order of execution ``` CUR_ForceFontDPIEnable=false [ $CUR_ForceFontDPI -gt 0 ] && CUR_ForceFontDPIEnable=true ```
MicheleC marked this conversation as resolved
SlavekB force-pushed issue/229/starttde-default-forceFontDPIEnable from e3d6d24b51 to 48077a30f9 3 years ago
SlavekB requested review from MicheleC 3 years ago
MicheleC approved these changes 3 years ago
MicheleC left a comment
Owner

Looks good now

Looks good now
SlavekB merged commit 48077a30f9 into master 3 years ago
SlavekB deleted branch issue/229/starttde-default-forceFontDPIEnable 3 years ago

Reviewers

MicheleC approved these changes 3 years ago
The pull request has been merged as 48077a30f9.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#231
Loading…
There is no content yet.