TDEMenu shortcuts: Additional checks/fixes #232
Merged
blu.256
merged 1 commits from fix/kmenu-shortcut-checks into master 3 years ago
SlavekB
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'fix/kmenu-shortcut-checks'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Please test:
If all's okay, then I can squash the commits and merge the PR.
It seems there is a change in the code that was intended differently.
See comment below.
c->setGroup("KMenu");m_searchShortcut->setShortcut(TDEShortcut(c->readEntry("SearchShortcut", "/")));m_searchShortcut->setShortcut(TDEShortcut(c->readEntry("SearchShortcut", "/"))), false;At first glance, this does not look like the intended result. I assume that
falsewas supposed to be as an argument forsetShortcut– so before parenthesis?Strange that it didn't break the build for me. Yes, it should have been before the last parens as an argument for
setShortcut. Fixing this.Yes, it does not cause FTBFS because there was this
falsebasically completely ignored ==falsethere had no effect or meaning, but did not cause an error in syntax.Thank you, I assumed it exactly and therefore I built it with such a modification for performing the tests.
cdb0710583tod26e5f7c173 years agod26e5f7c17to89449e19603 years agoI did tests and it seems, everything works as intended.
Okay, then I'm merging this.
Thanks for testing, Slávek.
89449e1960to10cddab2e33 years ago10cddab2e3into master 3 years agoThanks Philippe, it works fine. May I suggest a minor rewording?
From: Cannot set Escape as menu search shortcut.
To: Escape cannot be used as a shortcut for the menu search field.
Reviewers
10cddab2e3.