Fixed rendering of bold text color.
#233
Closed
MicheleC
wants to merge 1 commits from fix/bold-cold
into master
pull from: fix/bold-cold
merge into: TDE:master
TDE:r14.1.x
TDE:master
TDE:fix/kxkb-450
TDE:feat/shutdownd-dialog-border
TDE:feat/whatever
TDE:feat/kdesktop
TDE:feat/layouts
TDE:issue/270/tdebase
TDE:r14.0.x
TDE:v3.5.13-sru
TDE:issue/227
TDE:fix/kicker-clock-build-dependency
TDE:feat/pkg-config
TDE:branding/kde_to_tde2
TDE:feat/fix-suspend-code
Reviewers
Request review
No reviewers
Labels
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label
GE/need-info
PR/keep-branch
PR/not-ok
PR/rfc
PR/update-trans
PR/wip
RS/R14.0.x
RS/R14.1.x
SL/critical
SL/major
SL/minor
SL/normal
SL/regression
SL/trivial
SL/wishlist
ST/duplicate
ST/invalid
ST/notourproblem
ST/rejected
ST/wontfix
ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: TDE/tdebase#233
Reference in new issue
There is no content yet.
Delete Branch 'fix/bold-cold'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
As per title.
This replace and fix this commit from PR#184.
It seems that correct rendering is obtained without using any intensive setting. Could you test on your system too?
How to test: run the following command on a Konsole without and with the fix.
Attached result with this PR (left without, right with). Compared to results in this comment
This completely doesn't work.
Because Konsole does not use bold font, the demand for BOLD is realized by highlighting the color – instead of gray is used white, instead of brown is used yellow. Patch in this PR completely breaks this functionality. While the patch 45860f8b6a solves the situation where little intense color is used to highlight already highlighted color => brown is used to highlight yellow.
Note: For test you can use
echo -e "NORMAL \e[1mBOLD\e[0m"
ah, of course!! My mistake!! Totally forgot about how BOLD colors are rendered!
Sorry, disregard this PR completely.
Reviewers