Fixed rendering of bold text color. #233

Closed
MicheleC wants to merge 1 commits from fix/bold-cold into master
Owner

As per title.
This replace and fix this commit from PR#184.
It seems that correct rendering is obtained without using any intensive setting. Could you test on your system too?

How to test: run the following command on a Konsole without and with the fix.

echo -e "\e[93m YELLOW \e[0m \e[4;93m UNDERLINED \e[0m \e[1;93m BOLD \e[0m" &&
echo -e "\e[33m ORANGE \e[0m \e[4;33m UNDERLINED \e[0m \e[1;33m BOLD \e[0m"

Attached result with this PR (left without, right with). Compared to results in this comment

As per title. This replace and fix [this commit](https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/commit/45860f8b6a00578817aa864f44907ba0893d7be1) from PR#184. It seems that correct rendering is obtained without using any intensive setting. Could you test on your system too? How to test: run the following command on a Konsole without and with the fix. ``` echo -e "\e[93m YELLOW \e[0m \e[4;93m UNDERLINED \e[0m \e[1;93m BOLD \e[0m" && echo -e "\e[33m ORANGE \e[0m \e[4;33m UNDERLINED \e[0m \e[1;33m BOLD \e[0m" ``` Attached result with this PR (left without, right with). Compared to results in [this comment](https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/184#issuecomment-15542)
MicheleC added 1 commit 3 years ago
df830fcd25
Fixed rendering of bold text color.
MicheleC added this to the R14.0.11 release milestone 3 years ago
SlavekB requested changes 3 years ago
SlavekB left a comment
Owner

This completely doesn't work.

Because Konsole does not use bold font, the demand for BOLD is realized by highlighting the color – instead of gray is used white, instead of brown is used yellow. Patch in this PR completely breaks this functionality. While the patch 45860f8b6a solves the situation where little intense color is used to highlight already highlighted color => brown is used to highlight yellow.

This completely doesn't work. Because Konsole does not use **bold** font, the demand for BOLD is realized by highlighting the color – instead of gray is used white, instead of brown is used yellow. Patch in this PR completely breaks this functionality. While the patch 45860f8b6a solves the situation where little intense color is used to highlight already highlighted color => brown is used to highlight yellow.
Owner

Note: For test you can use echo -e "NORMAL \e[1mBOLD\e[0m"

Note: For test you can use `echo -e "NORMAL \e[1mBOLD\e[0m"`
Poster
Owner

ah, of course!! My mistake!! Totally forgot about how BOLD colors are rendered!
Sorry, disregard this PR completely.

ah, of course!! My mistake!! Totally forgot about how BOLD colors are rendered! Sorry, disregard this PR completely.
MicheleC closed this pull request 3 years ago
MicheleC removed this from the R14.0.11 release milestone 3 years ago
MicheleC deleted branch fix/bold-cold 3 years ago

Reviewers

SlavekB requested changes 3 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#233
Loading…
There is no content yet.