TDE
/
tdebase
9
4
Fork 2
Code Issues 105 Pull Requests 6 Releases Wiki Activity
Labels Milestones
New Issue

Wrong doc path in comment in /etc/trinity/tdm/tdmrc #249

Closed
opened 2 years ago by mgb · 3 comments
mgb commented 2 years ago

Basic information

  • TDE version: R14.0.11
  • Distribution: Debian Bullseye
  • Hardware: amd64

Description

Package tdm-trinity contains file /etc/trinity/tdm/tdmrc which says:

See /usr/share/doc/tdm/README.Debian for details

but the correct path is /usr/share/doc/tdm-trinity/README.Debian

Steps to reproduce

Screenshots

<!-- This is a comment. Please fill in the required fields below. The comments provide instructions on how to do so. Note: You do not need to remove comments. --> ## Basic information - TDE version: R14.0.11 - Distribution: Debian Bullseye - Hardware: amd64 <!-- Use SL/* labels to set the severity level. Please do not set a milestone. --> ## Description Package tdm-trinity contains file /etc/trinity/tdm/tdmrc which says: ``` See /usr/share/doc/tdm/README.Debian for details ``` but the correct path is /usr/share/doc/tdm-trinity/README.Debian ## Steps to reproduce ## Screenshots <!-- If it seems useful, please provide provide one or more screenshots. -->
MicheleC commented 2 years ago
Owner

The question is whether that sentence should be part of the main TDE repo code or not, because it refers to a file that is only present in Debian-based distros.
It would probably be wiser to remove the line since that file won't be present in rpm-based distros for example.
An alternative could be to add the info in README.Debian to the main repo after purging debian specific parts.

@SlavekB what do you think?

The question is whether that sentence should be part of the main TDE repo code or not, because it refers to a file that is only present in Debian-based distros. It would probably be wiser to remove the line since that file won't be present in rpm-based distros for example. An alternative could be to add the info in README.Debian to the main repo after purging debian specific parts. @SlavekB what do you think?
SlavekB commented 2 years ago
Owner

Yes, I also looked for where this link is written and I was also surprised that it is in main repository, not in tde-packaging, although the referenced file is part of tde-packaging.

Here it would make sense that mentioning the readme file specific to distribution was more general, where README.Debian can be mentioned as an example of possible file locations.

Yes, I also looked for where this link is written and I was also surprised that it is in main repository, not in tde-packaging, although the referenced file is part of tde-packaging. Here it would make sense that mentioning the readme file specific to distribution was more general, where README.Debian can be mentioned as an example of possible file locations.
MicheleC commented 2 years ago
Owner

Addressed by commits above. Thanks Mike for reporting it.

Addressed by commits above. Thanks Mike for reporting it.
MicheleC closed this issue 2 years ago
MicheleC added this to the R14.0.12 release milestone 2 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
r14.1.x
master
fix/konsole-reset-tab-color
r14.0.x
issue/270/tdebase
v3.5.13-sru
issue/227
fix/kicker-clock-build-dependency
feat/pkg-config
branding/kde_to_tde2
feat/fix-suspend-code
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.12 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#249
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes