Konqueror does not see metadata in properties for audio mp3 file #258

Closed
opened 2 years ago by VinceR · 2 comments
VinceR commented 2 years ago
Collaborator

Konqueror does display metadata in properties for mp3 audio files.

Basic information

  • TDE version: 14.1
  • TDE component: tdemultimedia/tdefile-plugins/mp3 (compiled with taglib support)
  • Distribution: Gentoo
  • Other relevant packages
    • shared-mime-info: 2.1
    • taglib: 1.12

Analysis

  • MP3 audio files are assigned the canonical mimetype "audio/mpeg", at least on my system.
  • The plugin tdefile_mp3 is configured only to handle "audio/x-mp3" which is a mimetype alias.
  • Attached patch remedies the problem by adding "audio/mpeg" to Mimetype= line in file share/services/tdefile_mp3.desktop and replacing hardcoded "audio/x-mp3" in code with mimetype variable that is passed to plugin. Will generate PR if desired.
Konqueror does display metadata in properties for mp3 audio files. ## Basic information - TDE version: 14.1 - TDE component: *tdemultimedia/tdefile-plugins/mp3* (compiled with taglib support) - Distribution: Gentoo - Other relevant packages - shared-mime-info: 2.1 - taglib: 1.12 ## Analysis - MP3 audio files are assigned the canonical mimetype "audio/mpeg", at least on my system. - The plugin tdefile_mp3 is configured only to handle "audio/x-mp3" which is a mimetype alias. - Attached patch remedies the problem by adding "audio/mpeg" to Mimetype= line in file *share/services/tdefile_mp3.desktop* and replacing hardcoded "audio/x-mp3" in code with mimetype variable that is passed to plugin. Will generate PR if desired.
VinceR added the SL/normal label 2 years ago
Owner

Hi @VinceR,
although it is a small patch, can you make a proper PR for this? It is easier to merge and the commit will be credited to you.

Hi @VinceR, although it is a small patch, can you make a proper PR for this? It is easier to merge and the commit will be credited to you.
VinceR commented 2 years ago
Poster
Collaborator

I erroneously created this issue in TDE/tdebase but it really belongs under TDE/tdemultimedia. I am going to try to close this issue and start a new one over there.

I erroneously created this issue in TDE/tdebase but it really belongs under TDE/tdemultimedia. I am going to try to close this issue and start a new one over there.
VinceR closed this issue 2 years ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#258
Loading…
There is no content yet.