TDE
/
tdebase
9
4
Fork 1
Code Issues 115 Pull Requests 10 Releases Wiki Activity
Labels Milestones
New Issue

No GUI control to disable the login startup dialog #314

Open
opened 1 year ago by Woodsman · 6 comments
Woodsman commented 1 year ago
Collaborator

Basic information

  • TDE version: ALL
  • Distribution: ALL
  • Hardware: N/A

Description

A startup dialog appears when a user disables the login splash screen. For many people, selecting "None" means none and the dialog is not wanted.

There is no GUI control to disable this dialog.

There is a manual solution. In $TDEHOME/share/config/ksmserverrc add the following:

[Login]
showFancyLogin=false

A GUI control should be added. A suitable location might be TCC-->Session Manager-->On Login. To be consistent the check box should be 'Show login status dialog'.

Perhaps the new check box should toggle to disabled when the user selects a login splash and vice-versa.

Steps to reproduce

  1. In TCC-->Appearance & Themes-->Splash Screen, select None to disable the login splash.
  2. Log out and log in.
  3. Notice the startup dialog. The dialog will display "Loading your settings...."
## Basic information - TDE version: ALL - Distribution: ALL - Hardware: N/A ## Description A startup dialog appears when a user disables the login splash screen. For many people, selecting "None" means none and the dialog is not wanted. There is no GUI control to disable this dialog. There is a manual solution. In $TDEHOME/share/config/ksmserverrc add the following: [Login] showFancyLogin=false A GUI control should be added. A suitable location might be TCC-->Session Manager-->On Login. To be consistent the check box should be 'Show login status dialog'. Perhaps the new check box should toggle to disabled when the user selects a login splash and vice-versa. ## Steps to reproduce 1. In TCC-->Appearance & Themes-->Splash Screen, select None to disable the login splash. 2. Log out and log in. 3. Notice the startup dialog. The dialog will display "Loading your settings...."
MicheleC commented 1 year ago
Owner

Uhm, I tried the exact same steps and don't see any dialog showing up if I select "None".

Uhm, I tried the exact same steps and don't see any dialog showing up if I select "None".
MicheleC commented 1 year ago
Owner

Interestingly, I see different behavior if I login as a root or non-root user. With non-root user I see that little dialog, with root I don't.
Can you confirm the same behavior?

Interestingly, I see different behavior if I login as a root or non-root user. With non-root user I see that little dialog, with root I don't. Can you confirm the same behavior?
blu.256 commented 1 year ago
Collaborator

This check looks wrong:
https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/ksmserver/startup.cpp#L101

If the theme is not Unified then we enable the "Loading your settings...." dialog (implemented in https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/ksmserver/startupdlg.cpp). IMO that must be the root of the problem: we mustn't enable the dialog if the theme has the None value. Why "Unified" is there in the first place confuses me though.

This check looks wrong: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/ksmserver/startup.cpp#L101 If the theme is not Unified then we enable the "Loading your settings...." dialog (implemented in https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/ksmserver/startupdlg.cpp). IMO that must be the root of the problem: we mustn't enable the dialog if the theme has the None value. Why "Unified" is there in the first place confuses me though.
blu.256 commented 1 year ago
Collaborator

Uhm, I tried the exact same steps and don't see any dialog showing up if I select "None".

What does kreadconfig --file ksmserverrc --group Login --key showFancyLogin return in each case? Whether you see the dialog seems to depend on the value of this option. (Note that the option might be unset, so the return will be an empty line).

> Uhm, I tried the exact same steps and don't see any dialog showing up if I select "None". What does `kreadconfig --file ksmserverrc --group Login --key showFancyLogin` return in each case? Whether you see the dialog [seems to depend](https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/ksmserver/startup.cpp#L145) on the value of this option. (Note that the option might be unset, so the return will be an empty line).
MicheleC commented 1 year ago
Owner

This check looks wrong:
https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/ksmserver/startup.cpp#L101

If the theme is not Unified then we enable the "Loading your settings...." dialog (implemented in https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/ksmserver/startupdlg.cpp). IMO that must be the root of the problem: we mustn't enable the dialog if the theme has the None value. Why "Unified" is there in the first place confuses me though.

Uhm.... it may be the problem but it sounds strange to me. If the test was wrong, I would expect any theme other than Unified or None not to work and always show the simple dialog window. I think more investigation may be required to have a wider understanding of the problem.

> This check looks wrong: > https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/ksmserver/startup.cpp#L101 > > If the theme is not Unified then we enable the "Loading your settings...." dialog (implemented in https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/ksmserver/startupdlg.cpp). IMO that must be the root of the problem: we mustn't enable the dialog if the theme has the None value. Why "Unified" is there in the first place confuses me though. Uhm.... it may be the problem but it sounds strange to me. If the test was wrong, I would expect any theme other than Unified or None not to work and always show the simple dialog window. I think more investigation may be required to have a wider understanding of the problem.
MicheleC commented 1 year ago
Owner

Uhm, I tried the exact same steps and don't see any dialog showing up if I select "None".

What does kreadconfig --file ksmserverrc --group Login --key showFancyLogin return in each case? Whether you see the dialog seems to depend on the value of this option. (Note that the option might be unset, so the return will be an empty line).

I checked for user config files and both don't have any specific settings for showFancyLogin

> > Uhm, I tried the exact same steps and don't see any dialog showing up if I select "None". > > What does `kreadconfig --file ksmserverrc --group Login --key showFancyLogin` return in each case? Whether you see the dialog [seems to depend](https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/branch/master/ksmserver/startup.cpp#L145) on the value of this option. (Note that the option might be unset, so the return will be an empty line). I checked for user config files and both don't have any specific settings for `showFancyLogin`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
r14.1.x
master
fix/kxkb-450
feat/shutdownd-dialog-border
feat/whatever
feat/kdesktop
feat/layouts
issue/270/tdebase
r14.0.x
v3.5.13-sru
issue/227
fix/kicker-clock-build-dependency
feat/pkg-config
branding/kde_to_tde2
feat/fix-suspend-code
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#314
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes