[ksysguardd] Use size_t for storing process memory usage on Linux. #346

My first commit to TDE... this looks like it needs doing for other platforms too, but I don't have FreeBSD/etc test machines running TDE handy.

Hi David,
welcome to TDE!

My first commit to TDE...

Looking forward for many more :-)

this looks like it needs doing for other platforms too, but I don't have FreeBSD/etc test machines running TDE handy.

In order for this commit to be merged, we need your help to create a PR following the "shared collaboration with branches" model, as explained here
It may look an annoying formality, but it is actually very important because 1. it keeps the commit history clean of "merge" commits (I won't go into why "merge" commits are annoying here, but happy to explain more if you want to know) and 2. avoid lots of forks, which may become a problem im future given that this server has limited disk space.
I have already added you as "contributor" so you should have no problems following the instructions at the link above.

Again welcome and hopefully that "first" commit will be the first of many :-)

Thanks for the details and adding me as a contributor, I'll delete my fork and set up the PR as required in the week, might spin up some BSD VMs so I can verify this on them too.

Just another question - is there any kind of CI configured for the TDE repos?

It is not necessary to close this PR. We can complete revise and merger in this fork. It is important that we can make merge linearly, without unwanted merge commits. Once it has been successfully completed, you will be able to remove your fork.

Currently there is no automatic CI. Creating the source and building binary deb packages is activated and performed by semi-automatic. Pakcages are subsequently available in APT repositories known as PSB and PTB. However, yes, it is planned to add automated processing.

It is not necessary to close this PR. We can complete revise and merger in this fork

@SlavekB I think this is not advisable. Remember that we link selected PRs into release notes and that TGW history also links to the original branch once a PR is merged.
If we merge from the fork and later delete the fork, those links would become invalid, so I think it is better to follow the usual steps, creating and merging a PR from the main repository rather than a fork. This way we avoid any risk of invalid links.

@solemnwarning in case you are not aware, PSB/PTB are rolling releases of the current stable and testing versions (see here and referenced links). Anyway they are not a CI environment, since those packages are built aftera commit is merged. As Slavek said, setting up a CI is something we talked about but we haven't yet implemented.

Yes @MicheleC, you are right that the merge from fork can cause links to non-existent commits, and that it is preferable to make PR on the main git repository.

Thanks for the details and adding me as a contributor, I'll delete my fork and set up the PR as required in the week, might spin up some BSD VMs so I can verify this on them too.

@solemnwarning
David, please proceed this way and thanks for the patch :-)

Moved here: #350