KLayouts: Restoring the default behaviour for system layouts #416

Open
roman wants to merge 1 commits from feat/layouts into master
roman commented 4 months ago
Collaborator

Signed-off-by: Roman Savochenko roman@home.home

That is the same patch from here https://bugs.pearsoncomputing.net/show_bug.cgi?id=3205 which adapted to 14.1.1, so it is performed:
• loading the system XKB configuration at disabling TDE Layouts with overriding the XKB options from the tab "Options Xkb";
• applying TDE Layouts at its enable;
• removing the controversial part "Modes" in the tab "Options Xkb".

Signed-off-by: Roman Savochenko <roman@home.home> That is the same patch from here https://bugs.pearsoncomputing.net/show_bug.cgi?id=3205 which adapted to 14.1.1, so it is performed: • loading the system XKB configuration at disabling TDE Layouts with overriding the XKB options from the tab "Options Xkb"; • applying TDE Layouts at its enable; • removing the controversial part "Modes" in the tab "Options Xkb".
roman added 1 commit 4 months ago
91724d24fc
KLayouts: Restoring the default behaviour for system layouts
roman added the SL/minor SL/regression labels 4 months ago
Collaborator

Could you please clarify what issues this fixes for you? For example, I struggle to understand why you had to modify the init function for the keyboard layout configuration module in this way. Also, why you chose to remove the "Modes" feature without prior discussion on TGW, taking into account that it has been already discussed in #304 which resulted in keeping it and enhancing it.

Could you please clarify what issues this fixes for you? For example, I struggle to understand why you had to modify the init function for the keyboard layout configuration module in this way. Also, why you chose to remove the "Modes" feature without prior discussion on TGW, taking into account that it has been already discussed in #304 which resulted in keeping it and enhancing it.
roman commented 4 months ago
Poster
Collaborator

Could you please clarify what issues this fixes for you?

It allows me to use the layouts configuration from /etc/default/keyboard, as that wrote in the initial issue #415, when shortly.

I struggle to understand why you had to modify the init function for the keyboard layout configuration module in this way.

Maybe in this way it works? :)

Also, why you chose to remove the "Modes" feature without prior discussion on TGW, taking into account that it has been already discussed in #304 which resulted in keeping it and enhancing it.

Due to it is completely spare for me and only mulls. Also it conflicts together reading and saving the system layout configuration with disabled TDE Layouts.

Just apply this patch and you'll understand all, or use my LiveDisks with all my patches — http://oscada.org/wiki/Special:MyLanguage/Sub-projects/Automation_Linux_distributive

> Could you please clarify what issues this fixes for you? It allows me to use the layouts configuration from /etc/default/keyboard, as that wrote in the initial issue https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/415, when shortly. > I struggle to understand why you had to modify the init function for the keyboard layout configuration module in this way. Maybe in this way it works? :) > Also, why you chose to remove the "Modes" feature without prior discussion on TGW, taking into account that it has been already discussed in #304 which resulted in keeping it and enhancing it. Due to it is completely spare for me and only mulls. Also it conflicts together reading and saving the system layout configuration with disabled TDE Layouts. Just apply this patch and you'll understand all, or use my LiveDisks with all my patches — http://oscada.org/wiki/Special:MyLanguage/Sub-projects/Automation_Linux_distributive
MicheleC requested changes 4 months ago
MicheleC left a comment
Owner

This PR won't be accepted because it removes useful functionality that was introduced in R14.1.0 and enhanced in R14.1.1.

This PR won't be accepted because it removes useful functionality that was introduced in R14.1.0 and enhanced in R14.1.1.

Reviewers

MicheleC requested changes 4 months ago
This pull request has changes conflicting with the target branch.
kxkb/extension.cpp
kxkb/kcmlayout.cpp
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Reference: TDE/tdebase#416
Loading…
There is no content yet.