KLayouts: Restoring the default behaviour for system layouts
#416
Open
roman
wants to merge 1 commits from feat/layouts
into master
pull from: feat/layouts
merge into: TDE:master
TDE:r14.1.x
TDE:master
TDE:feat/shutdownd-dialog-border
TDE:feat/whatever
TDE:feat/kdesktop
TDE:issue/270/tdebase
TDE:r14.0.x
TDE:v3.5.13-sru
TDE:issue/227
TDE:fix/kicker-clock-build-dependency
TDE:feat/pkg-config
TDE:branding/kde_to_tde2
TDE:feat/fix-suspend-code
Reviewers
Request review
No reviewers
Labels
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label
GE/need-info
PR/keep-branch
PR/not-ok
PR/rfc
PR/update-trans
PR/wip
RS/R14.0.x
RS/R14.1.x
SL/critical
SL/major
SL/minor
SL/normal
SL/regression
SL/trivial
SL/wishlist
ST/duplicate
ST/invalid
ST/notourproblem
ST/rejected
ST/wontfix
ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Blocks
Reference: TDE/tdebase#416
Reference in new issue
There is no content yet.
Delete Branch 'feat/layouts'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
Signed-off-by: Roman Savochenko roman@home.home
That is the same patch from here https://bugs.pearsoncomputing.net/show_bug.cgi?id=3205 which adapted to 14.1.1, so it is performed:
• loading the system XKB configuration at disabling TDE Layouts with overriding the XKB options from the tab "Options Xkb";
• applying TDE Layouts at its enable;
• removing the controversial part "Modes" in the tab "Options Xkb".
Could you please clarify what issues this fixes for you? For example, I struggle to understand why you had to modify the init function for the keyboard layout configuration module in this way. Also, why you chose to remove the "Modes" feature without prior discussion on TGW, taking into account that it has been already discussed in #304 which resulted in keeping it and enhancing it.
It allows me to use the layouts configuration from /etc/default/keyboard, as that wrote in the initial issue #415, when shortly.
Maybe in this way it works? :)
Due to it is completely spare for me and only mulls. Also it conflicts together reading and saving the system layout configuration with disabled TDE Layouts.
Just apply this patch and you'll understand all, or use my LiveDisks with all my patches — http://oscada.org/wiki/Special:MyLanguage/Sub-projects/Automation_Linux_distributive
This PR won't be accepted because it removes useful functionality that was introduced in R14.1.0 and enhanced in R14.1.1.
Reviewers