KDesktop unlock dialog lacks a button pixmap for unlock. #76
Open
opened 5 years ago by Chris
·
1 comments
Loading…
Reference in new issue
There is no content yet.
Delete Branch '%!s(<nil>)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
It seems at least in R14.x (Not tested in stable) the unlock dialog lacks a pixmap for the unlock button.
"Switch user" and "Cancel" have their pixmaps in this dialog.
The "unlock" icon would fit perfectly.
But after that, I thought that Micheles new "device unlock" code could also use such an icon.
So I had the idea if it would not be of great benefit for TDE to add it to this place:
Because the "cancel" button in this dialog is also using it:
Such "lock" and "unlock" std-buttons could be re-used so fine in TDE.
The same could be done for "Hibernation" and "Suspend" or so. To finaly mainstream different icons for the shutdown dialog and TDEPowersave? I don't know. Just ideas.
A few comments here.
the "device unlock" in new PR for LUKS refers to unlocking an encrypted device.
Nevertheless, the unlock icon could be used also for "unlock" in kdesktop lock dialog. It does not need a new icon in the standard items, just need to add it to the lock button when creating the dialog.
The lock and unlock icons are already there and can be easily reused already
Regarding icons in shutdown and TDEPowersave, we should aim at using the same icon in both places for the same action. Different actions could have different icons, of course.