WIP: Make the menu a bit greater.
#81
Closed
Chris
wants to merge 1 commits from clean/menus
into master
pull from: clean/menus
merge into: TDE:master
TDE:r14.1.x
TDE:master
TDE:fix/kxkb-450
TDE:feat/shutdownd-dialog-border
TDE:feat/whatever
TDE:feat/kdesktop
TDE:feat/layouts
TDE:issue/270/tdebase
TDE:r14.0.x
TDE:v3.5.13-sru
TDE:issue/227
TDE:fix/kicker-clock-build-dependency
TDE:feat/pkg-config
TDE:branding/kde_to_tde2
TDE:feat/fix-suspend-code
Reviewers
Request review
No reviewers
Labels
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label
GE/need-info
PR/keep-branch
PR/not-ok
PR/rfc
PR/update-trans
PR/wip
RS/R14.0.x
RS/R14.1.x
SL/critical
SL/major
SL/minor
SL/normal
SL/regression
SL/trivial
SL/wishlist
ST/duplicate
ST/invalid
ST/notourproblem
ST/rejected
ST/wontfix
ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: TDE/tdebase#81
Reference in new issue
There is no content yet.
Delete Branch 'clean/menus'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
This PR has the intention to fix up the TDE menu a bit, add missing translations and icons and add missing XDG menu categories and polish them a bit.
Seems this one was still a outdated file in KDE2 times or so. Because XDG says, there is only a "science" category and it has submenus, like "math" and so on. Also TDE has already an very good science icon.
Signed-off-by: Chris xchrisx@uber.space
In tde-system-su.directory:
Name[fr]=Administrateur
Name[it]=Amministratore del sistema
@Chris what the status of this PR? I know it says there is a conflict, but beside that would it be considered as a PR ready for merging?
Right, I decided to split that work up into a smaler piece, because I wanted users to benefit from that in the R14.0.7 release. So I used all from that, what could be used already in #108, which was merged already.
This one, I will re-use now for other that related work.
Great. Once you have prepare a separate PR, please let us know. We can merge the new PR, close this one and #75 and delete that branch in #75.
Once this PR is closed, then it will be possible to delete the branch in this PR, thereby removing the branch displayed for both PRs.
Incidentally, this confirms the fact that it would be a good idea to create branches with a more accurate name to avoid overlaps with previously used branches.
@SlavekB: Yes, that's a good point. I just wanted to make that name not too specific, because I wasn't sure what comes out of this later and I don't wanted to make it too complex or long. But seems using some - here to add something is reasonable.
@MicheleC: Sure. 😄
I rebased the branch to the current HEAD and merged the changes that took place during that time – such as extracting translations from desktop files into PO files.
so what is the status on this PR? Ready for testing and then merging?
I have no idea if there are any other things that Chris intended to do in this PR. All I did now was move the existing patch to match the current state of the code. Here we will need to activate @Chris for him to look at it.
ok understood. Thanks for the explanation Slavek.
@SlavekB
EDIT: original PR did more work, which was separated and merged through other PRs. So the question is just about what is left here.
How about we close and discard this PR?
First it has been sitting here for 2 years and Chris has been MIA for about the same time.
Second: it adds a distro-specific (debian) file to TDE, which is not quite right to me. Moreover the file is added in applnk/, when we are trying to remove that folder completely.
Third: tdesu is about password and superuser. I don't see the link to "Wizard".
What do you think?
not specifics to tdebase, please also consider deleting all the old/unfinished PRs, so many branches everywhere makes everything a mess.
You can ask the original committer about his intents on this, then perform a cleanup.
Cleaning up is definitely good. Whether a PR needs to be deleted, merged or just kept open will depend on individual cases.
Yes, it seems that the purpose of this PR has already been fulfilled over time, and that the changes that remain here are not appropriate to merge. And because other intentions of the original author, who is unavailable in long-term, are unknown, it seems like a good time to close it.
Ok, will proceed then. Thanks for your feedback.