WIP: Make the menu a bit greater. #81

Closed
Chris wants to merge 1 commits from clean/menus into master
Chris commented 5 years ago
Collaborator

This PR has the intention to fix up the TDE menu a bit, add missing translations and icons and add missing XDG menu categories and polish them a bit.

  • Add icon to "science" category and fix name:

Seems this one was still a outdated file in KDE2 times or so. Because XDG says, there is only a "science" category and it has submenus, like "math" and so on. Also TDE has already an very good science icon.

  • Add icon and translations to "SuperUser" submenu
  • Add missing directory files for missing XDG application submenus (See other PR)
  • Mainstream and polish icons and translations of KDE submenus
  • Add some nice icon for Debian submenu
  • As discussed a bit already, look into removing the "X-TDE-More" categories and also the likely directory file
  • Investigate if there is still some sense in general to include prefix "X-TDE", because it seems TDE menu structure does not make use of that and while it made sense for KDE (if using in other DEs) to allow this to sort out KDE applications (in GNOME for example), I highly suspect that these days any other DE has some menu which sorts out TDE applications into a seperate "TDE" submenu
  • What makes sense also, because of the TDE dockbar (discussed here: #32) would be (especially if some dockapps would be imported as TDE dockapps package) to define some additional "X-TDE-Utilities-Dockapps" category and add or change the desktop files of our dockapps to use that, to allow TDE users to simply start them for the dockbar by this menu - Most dockapps lack sadly some desktop file and/or don't have a own category, so right way would be to submit this category to XDG officially maybe

Signed-off-by: Chris xchrisx@uber.space

This PR has the intention to fix up the TDE menu a bit, add missing translations and icons and add missing XDG menu categories and polish them a bit. - Add icon to "science" category and fix name: Seems this one was still a outdated file in KDE2 times or so. Because XDG says, there is only a "science" category and it has submenus, like "math" and so on. Also TDE has already an very good science icon. - Add icon and translations to "SuperUser" submenu - Add missing directory files for missing XDG application submenus (See other PR) - Mainstream and polish icons and translations of KDE submenus - Add some nice icon for Debian submenu - As discussed a bit already, look into removing the "X-TDE-More" categories and also the likely directory file - Investigate if there is still some sense in general to include prefix "X-TDE", because it seems TDE menu structure does not make use of that and while it made sense for KDE (if using in other DEs) to allow this to sort out KDE applications (in GNOME for example), I highly suspect that these days any other DE has some menu which sorts out TDE applications into a seperate "TDE" submenu - What makes sense also, because of the TDE dockbar (discussed here: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/32) would be (especially if some dockapps would be imported as TDE dockapps package) to define some additional "X-TDE-Utilities-Dockapps" category and add or change the desktop files of our dockapps to use that, to allow TDE users to simply start them for the dockbar by this menu - Most dockapps lack sadly some desktop file and/or don't have a own category, so right way would be to submit this category to XDG officially maybe Signed-off-by: Chris <xchrisx@uber.space>
Chris added the PR/wip label 5 years ago
Ghost commented 5 years ago

In tde-system-su.directory:

Name[fr]=Administrateur

In tde-system-su.directory: Name[fr]=Administrateur
Owner

Name[it]=Amministratore del sistema

Name[it]=Amministratore del sistema
Owner

@Chris what the status of this PR? I know it says there is a conflict, but beside that would it be considered as a PR ready for merging?

@Chris what the status of this PR? I know it says there is a conflict, but beside that would it be considered as a PR ready for merging?
Chris commented 4 years ago
Poster
Collaborator

Right, I decided to split that work up into a smaler piece, because I wanted users to benefit from that in the R14.0.7 release. So I used all from that, what could be used already in #108, which was merged already.

This one, I will re-use now for other that related work.

Right, I decided to split that work up into a smaler piece, because I wanted users to benefit from that in the R14.0.7 release. So I used all from that, what could be used already in https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/pulls/108, which was merged already. This one, I will re-use now for other that related work.
Owner

Great. Once you have prepare a separate PR, please let us know. We can merge the new PR, close this one and #75 and delete that branch in #75.

Great. Once you have prepare a separate PR, please let us know. We can merge the new PR, close this one and #75 and delete that branch in #75.
Owner

Once this PR is closed, then it will be possible to delete the branch in this PR, thereby removing the branch displayed for both PRs.

Incidentally, this confirms the fact that it would be a good idea to create branches with a more accurate name to avoid overlaps with previously used branches.

Once this PR is closed, then it will be possible to delete the branch in this PR, thereby removing the branch displayed for both PRs. Incidentally, this confirms the fact that it would be a good idea to create branches with a more accurate name to avoid overlaps with previously used branches.
Chris commented 4 years ago
Poster
Collaborator

@SlavekB: Yes, that's a good point. I just wanted to make that name not too specific, because I wasn't sure what comes out of this later and I don't wanted to make it too complex or long. But seems using some - here to add something is reasonable.

@MicheleC: Sure. 😄

@SlavekB: Yes, that's a good point. I just wanted to make that name not too specific, because I wasn't sure what comes out of this later and I don't wanted to make it too complex or long. But seems using some *-* here to add something is reasonable. @MicheleC: Sure. :smile:
Owner

I rebased the branch to the current HEAD and merged the changes that took place during that time – such as extracting translations from desktop files into PO files.

I rebased the branch to the current HEAD and merged the changes that took place during that time – such as extracting translations from desktop files into PO files.
Owner

so what is the status on this PR? Ready for testing and then merging?

so what is the status on this PR? Ready for testing and then merging?
Owner

I have no idea if there are any other things that Chris intended to do in this PR. All I did now was move the existing patch to match the current state of the code. Here we will need to activate @Chris for him to look at it.

I have no idea if there are any other things that Chris intended to do in this PR. All I did now was move the existing patch to match the current state of the code. Here we will need to activate @Chris for him to look at it.
Owner

ok understood. Thanks for the explanation Slavek.

ok understood. Thanks for the explanation Slavek.
Owner

@SlavekB

EDIT: original PR did more work, which was separated and merged through other PRs. So the question is just about what is left here.

How about we close and discard this PR?
First it has been sitting here for 2 years and Chris has been MIA for about the same time.
Second: it adds a distro-specific (debian) file to TDE, which is not quite right to me. Moreover the file is added in applnk/, when we are trying to remove that folder completely.
Third: tdesu is about password and superuser. I don't see the link to "Wizard".

What do you think?

@SlavekB EDIT: original PR did more work, which was separated and merged through other PRs. So the question is just about what is left here. How about we close and discard this PR? First it has been sitting here for 2 years and Chris has been MIA for about the same time. Second: it adds a distro-specific (debian) file to TDE, which is not quite right to me. Moreover the file is added in applnk/, when we are trying to remove that folder completely. Third: tdesu is about password and superuser. I don't see the link to "Wizard". What do you think?
Ghost commented 3 years ago

How about we close and discard this PR?
First it has been sitting here for 2 years and Chris has been MIA for about the same time.
What do you think?

not specifics to tdebase, please also consider deleting all the old/unfinished PRs, so many branches everywhere makes everything a mess.
You can ask the original committer about his intents on this, then perform a cleanup.

> How about we close and discard this PR? > First it has been sitting here for 2 years and Chris has been MIA for about the same time. > What do you think? not specifics to tdebase, please also consider deleting all the old/unfinished PRs, so many branches everywhere makes everything a mess. You can ask the original committer about his intents on this, then perform a cleanup.
Owner

not specifics to tdebase, please also consider deleting all the old/unfinished PRs, so many branches everywhere makes everything a mess.
You can ask the original committer about his intents on this, then perform a cleanup.

Cleaning up is definitely good. Whether a PR needs to be deleted, merged or just kept open will depend on individual cases.

> not specifics to tdebase, please also consider deleting all the old/unfinished PRs, so many branches everywhere makes everything a mess. > You can ask the original committer about his intents on this, then perform a cleanup. > Cleaning up is definitely good. Whether a PR needs to be deleted, merged or just kept open will depend on individual cases.
Owner

Yes, it seems that the purpose of this PR has already been fulfilled over time, and that the changes that remain here are not appropriate to merge. And because other intentions of the original author, who is unavailable in long-term, are unknown, it seems like a good time to close it.

Yes, it seems that the purpose of this PR has already been fulfilled over time, and that the changes that remain here are not appropriate to merge. And because other intentions of the original author, who is unavailable in long-term, are unknown, it seems like a good time to close it.
Owner

Ok, will proceed then. Thanks for your feedback.

Ok, will proceed then. Thanks for your feedback.
MicheleC closed this pull request 3 years ago
MicheleC deleted branch clean/menus 3 years ago
MicheleC removed the PR/wip label 3 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#81
Loading…
There is no content yet.