#12 relates to bug 2618

Merged
MicheleC merged 3 commits from bug/2618/renameIcon into master 11 months ago

Some icons should be renamed tde*

Some icons should be renamed tde*
cethyel added the
PR/wip
label 11 months ago
MicheleC commented 11 months ago
Owner

Looks good to me. Can I merge or do you want to do more work on this? I see it is marked as WIP.

Looks good to me. Can I merge or do you want to do more work on this? I see it is marked as WIP.
cethyel commented 11 months ago
Poster

there’s some more to come…

there's some more to come...
cethyel commented 11 months ago
Poster

There’s an occurrence of kdelogo in:

doc/tdm/index.docbook
428:<filename>$<envar>TDEDIR</envar>/share/apps/tdm/pics/kdelogo.xpm</filename>

but I don’t have such pixmap icon in Slackware, might be a left off from Ubuntu.
Could be renamed tdelogo.png I guess.

There's an occurrence of kdelogo in: ``` doc/tdm/index.docbook 428:<filename>$<envar>TDEDIR</envar>/share/apps/tdm/pics/kdelogo.xpm</filename> ``` but I don't have such pixmap icon in Slackware, might be a left off from Ubuntu. Could be renamed tdelogo.png I guess.
MicheleC commented 11 months ago
Owner

icon is here:

tdebase/tdm/kfrontend/pics/kdelogo.png

Ok to rename in tdelogo.png, of course.

icon is here: tdebase/tdm/kfrontend/pics/kdelogo.png Ok to rename in tdelogo.png, of course.
MicheleC commented 11 months ago
Owner

sorry, didn’t notice the extension was different. I suggest to fix the docbook with the correct extension (.png instead of .xpm)

sorry, didn't notice the extension was different. I suggest to fix the docbook with the correct extension (.png instead of .xpm)
cethyel removed the
PR/wip
label 11 months ago
cethyel commented 11 months ago
Poster

Don’t think I’ll go further with this PR, please give It a spin!

Don't think I'll go further with this PR, please give It a spin!
MicheleC commented 11 months ago
Owner

This looks good. I will do a test build tomorrow and if all good, I will merge. Unless Slavek can test and merger earlier :wink:

This looks good. I will do a test build tomorrow and if all good, I will merge. Unless Slavek can test and merger earlier :wink:
MicheleC deleted branch bug/2618/renameIcon 11 months ago
SlavekB added this to the R14.0.6 release milestone 11 months ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.