#121 Removed kxdglauncher which is now no longer required.

Merged
MicheleC merged 3 commits from feat/kxdglauncher into master 3 weeks ago
MicheleC commented 1 month ago

This PR removes kxdglauncher completely.
Required TDE/tde-packaging#32 and TDE/tdelibs#69 to build.

For further comments see TDE/tdelibs#69

This PR removes kxdglauncher completely.<br/> Required TDE/tde-packaging#32 and TDE/tdelibs#69 to build.<br/> For further comments see TDE/tdelibs#69
MicheleC added this to the R14.1.0 release milestone 1 month ago
Chris commented 1 month ago
Collaborator

@MicheleC: So I did test your PR in combination with the tdelibs PR. I did rebuild libkonq, konqueror, kdesktop and tdelibs, which should reflect all changes. That worked.

First I have to say, that I also experienced the doubling of the sidbar icons. But this has to do with the issue already existing about this. And after I rebuild either libkonq, or konqueror, this doubling was triggered for me, which is exactly what was also described in the issue. So maybe this will not triggered for normal use. But interesting.

Sadly I have to say that my experience with that test was exactly the way I described it in the other PR. I started and end exactly up with missing dirs. Trying to open the documents icon on the desktop resulted just to end up in the / dir. Also the desktop folder was created - Yes, but not localized. So maybe it would be just good to integrate the prompter code again but just in tdelibs and for all other XDG dirs too, where you did your other work already.

Otherwise the document dir (and also no other XGD dirs) will be created. They weren't created. And this is just bad. So there was a reason to have it. Might be I did something wrong, but this use case just to create some plain user and to start a TDE session should just work userfriendly. And users should decide from begining if they want to create the translated directories, like “Schreibtisch” or if they want to keep it “Desktop”.

EDIT: Seems the XDG people just ripped of the German translation for Desktop now. So that might be right.

But for my testing in my existing session:

That worked like a charm for the desktop icon. :+1:

But in the sidebar of konqueror I just got some:

*Unknown Error Code - 1078245036 - Please sent some bugreport to...”

May I miss something to rebuild or can you confirm that? :sweat_smile:

@MicheleC: So I did test your PR in combination with the tdelibs PR. I did rebuild libkonq, konqueror, kdesktop and tdelibs, which should reflect all changes. That worked. First I have to say, that I also experienced the doubling of the sidbar icons. But this has to do with the issue already existing about this. And after I rebuild either libkonq, or konqueror, this doubling was triggered for me, which is exactly what was also described in the issue. So maybe this will not triggered for normal use. But interesting. Sadly I have to say that my experience with that test was exactly the way I described it in the other PR. I started and end exactly up with missing dirs. Trying to open the documents icon on the desktop resulted just to end up in the */* dir. Also the desktop folder was created - Yes, but not localized. So maybe it would be just good to integrate the prompter code again but just in tdelibs and for all other XDG dirs too, where you did your other work already. Otherwise the document dir (and also no other XGD dirs) will be created. They weren't created. And this is just bad. So there was a reason to have it. Might be I did something wrong, but this use case just to create some plain user and to start a TDE session should just work userfriendly. And users should decide from begining if they want to create the translated directories, like "Schreibtisch" or if they want to keep it "Desktop". EDIT: Seems the XDG people just ripped of the German translation for *Desktop* now. So that might be right. But for my testing in my existing session: That worked like a charm for the desktop icon. :+1: But in the sidebar of konqueror I just got some: *Unknown Error Code - 1078245036 - Please sent some bugreport to..." May I miss something to rebuild or can you confirm that? :sweat_smile:
Chris commented 1 month ago
Collaborator

Just to add: I also know now why the prompter code was triggered berfore with a new user session. The whole point about the old [$e] functionality was to trigger this things automaticly as known. So that triggered instantly the prompter when the desktop build up the first time and that secured to get prompted to create the missing dirs. Because the documents dir was just default on the desktop. Also if that was just used in kdesktop. We have to take that into account. If that code would be added now to tdelibs, that would work the same way. :smile_cat:

Just to add: I also know now why the prompter code was triggered berfore with a new user session. The whole point about the old [$e] functionality was to trigger this things automaticly as known. So that triggered instantly the prompter when the desktop build up the first time and that secured to get prompted to create the missing dirs. Because the documents dir was just default on the desktop. Also if that was *just* used in kdesktop. We have to take that into account. If that code would be added now to tdelibs, that would work the same way. :smile_cat:
Chris commented 1 month ago
Collaborator

Just some update. Just came about, I hadn't installed xdg-user-dirs anymore. But still preserving my old config. I will re-test now with it the same process.

Just some update. Just came about, I hadn't installed xdg-user-dirs anymore. But still preserving my old config. I will re-test now *with* it the same process.
Chris commented 1 month ago
Collaborator

So, after xdg-user-dir install:

Nothing changed, except the fact the user dirs are created now - Yes, but before that worked without any xdg-user-dirs it seems. It was just using the same config file.

So there is no real sense to handle the config file for the dirs by own code, if xdg-user-dirs is in fact some hard dependency, because otherwise the user dirs aren't created without having it, which lead to the result tested above. So if we have that config code handling, there should be also creating that file and that dirs by the prompter code again, with that having xdg-user-dirs installed at all would be not needed, just like before.

But besides it created now the documents dir and the other dirs, I ended up just in /, like before if I clicked on the documents icon. The error about the sidebar I still get. That all with a new user and a new session. Can you re-check that or I am missing something still? :confused:

EDIT: Doubling of sidebar entries is now permanent for me. That seems to be new.

EDIT2: All of the sudden, the sidebar doubling is gone. Mystical. :smile_cat:

EDIT3: I just did some further test, which seems to have worked before. If you have xdg-user-dirs installed, you create some user, you login the first time, all the missing user dirs get's created. But if you remove the documents folder, just re-login, the creating procedure seems to be not triggered. That end up with a broken documents icon on the desktop too. The old code would have prompted to create it and give it a name. So can we not just re-use the config file again and let's TDE keep care about the create process of the dirs itself, so xdg-user-dirs isn't needed at all, Michele?

EDIT4: I also tested to create some new user, without having xdg-user-dirs installed, but installed it afterwards and started a new session for this user. This time it worked and the missing dirs got created.

So, after xdg-user-dir install: Nothing changed, except the fact the user dirs are created now - Yes, but before that worked without any xdg-user-dirs it seems. It was just using the same config file. So there is no real sense to handle the config file for the dirs by own code, if xdg-user-dirs is in fact some hard dependency, because otherwise the user dirs aren't created without having it, which lead to the result tested above. So if we have that config code handling, there should be also creating that file and that dirs by the prompter code again, with that having xdg-user-dirs installed at all would be not needed, just like before. But besides it created now the documents dir and the other dirs, I ended up just in */*, like before if I clicked on the documents icon. The error about the sidebar I still get. That all with a new user and a new session. Can you re-check that or I am missing something still? :confused: EDIT: Doubling of sidebar entries is now permanent for me. That seems to be new. EDIT2: All of the sudden, the sidebar doubling is gone. Mystical. :smile_cat: EDIT3: I just did some further test, which seems to have worked before. If you have xdg-user-dirs installed, you create some user, you login the first time, all the missing user dirs get's created. But if you remove the documents folder, just re-login, the creating procedure seems to be not triggered. That end up with a broken documents icon on the desktop too. The old code would have prompted to create it and give it a name. So can we not just re-use the config file again and let's TDE keep care about the create process of the dirs itself, so xdg-user-dirs isn't needed at all, Michele? EDIT4: I also tested to create some new user, without having xdg-user-dirs installed, but installed it afterwards and started a new session for this user. This time it worked and the missing dirs got created.
MicheleC commented 1 month ago
Owner

Thanks Chris. Will look into it. It seems xdg-user-dirs is not required in Debian too (dependency could be removed).
Currently the default for missing folders is $HOME, but I guess we could have better default values.

Thanks Chris. Will look into it. It seems xdg-user-dirs is not required in Debian too (dependency could be removed).<br/> Currently the default for missing folders is $HOME, but I guess we could have better default values.<br/>
Chris commented 1 month ago
Collaborator

Good point, Michele. And yes, that would be wonderful. If you have some new ideas I will test again. Maybe I can find out about what is the message about the sidebar entry. We will see.

Good point, Michele. And yes, that would be wonderful. If you have some new ideas I will test again. Maybe I can find out about what is the message about the sidebar entry. We will see.
MicheleC commented 4 weeks ago
Owner

Updated. See comments in TDE/tdelibs#69 for extra info.

Updated. See comments in TDE/tdelibs#69 for extra info.
MicheleC commented 3 weeks ago
Owner

PR updated, looks fine now.

PR updated, looks fine now.
MicheleC modified the milestone from R14.1.0 release to R14.0.8 release 3 weeks ago
Chris commented 3 weeks ago
Collaborator

Already compiling for a last test, together with the tdelibs related PR. :smile:

Already compiling for a last test, together with the tdelibs related PR. :smile:
MicheleC deleted branch feat/kxdglauncher 3 weeks ago
The pull request has been merged as 234e466e0e.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.