ioctl(SIOCGIFHWADDR) portability improvements #146

Manually merged

obache merged 1 commits from feat/fix-siocgifhwaddr-portability into master

obache commented

Collaborator

For build fix on Solaris, has SIOCGIFHWADDR but missing ifreq->ifr_hwaddr.

obache changed title from ~~WIP: ioctl(SIOCGIFHWADDR) portability improvements~~ to ioctl(SIOCGIFHWADDR) portability improvements

SlavekB reviewed

SlavekB left a comment

Owner

It looks good, only two small comments…

ConfigureChecks.cmake Outdated

													
					tde_setup_architecture_flags( )

					include(TestBigEndian)

					include(CheckStructHasMember)

SlavekB commented

Owner

This include seems unnecessary because it is already contained in CMakeListst.txt.

ConfigureChecks.cmake Outdated

													
					endif( )

					# ioctl(SIOCGIFHWADDR) return member

					if( BUILD_KCONTROL )

SlavekB commented

Owner

This check could be moved to ConfigureChecks.cmake, which is inside the kcontrol directory.

SlavekB commented

Owner

rebased to the current HEAD
minor adjustments as indicated

obache closed this pull request

SlavekB deleted branch feat/fix-siocgifhwaddr-portability

SlavekB added this to the R14.0.9 release milestone

The pull request has been manually merged as 5bcd375ab5.

Sign in to join this conversation.

No reviewers

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#146