Issue #1: Konqueror shows "new file" icon on location bar for / folder #192

Closed
blu.256 wants to merge 1 commits from issue/1 into master
Collaborator

This is a little fix for Konqueror which makes it show the correct ("folder_red") icon for the root (/) directory.

For this to work you might have to clear Konqueror's icon cache, stored in file ~/.trinity/share/config/konq_history.

Comments and suggestions are welcome.

This is a little fix for Konqueror which makes it show the correct ("folder_red") icon for the root (/) directory. For this to work you might have to clear Konqueror's icon cache, stored in file ~/.trinity/share/config/konq_history. Comments and suggestions are welcome.
blu.256 added the PR/rfc label 3 years ago
blu.256 force-pushed issue/1 from 9db7e59337 to 904ad624d6 3 years ago
Owner

The selected icon seems like an interesting idea (originally there was just an ordinary directory icon). Interesting challenge is also the possibility of closing the first issue. But it is a question whether the right should be started analyzing in the KMimeType::iconForURL(...) in tdelibs because the same case can also be reflected in other uses?

The selected icon seems like an interesting idea (originally there was just an ordinary directory icon). Interesting challenge is also the possibility of closing the first issue. But it is a question whether the right should be started analyzing in the [`KMimeType::iconForURL(...)`](../tdelibs/src/branch/master/tdeio/tdeio/kmimetype.cpp#L507) in tdelibs because the same case can also be reflected in other uses?
Owner

I also think it would be better to fix this on the iconForUrl() method, because doing so would ensure consistency across various TDE applications. For example thinks of open/save dialogs used by most of the programs. Or dolphin and krusader file manager.

I also think it would be better to fix this on the iconForUrl() method, because doing so would ensure consistency across various TDE applications. For example thinks of open/save dialogs used by most of the programs. Or dolphin and krusader file manager.
Poster
Collaborator

Sounds reasonable, even though the only place I've encountered this bug is actually Konqueror.

You do agree with the folder_red icon? I used this because I've seen it used for representing / in some other places.

Could somebody please point me where to look for KMimeType sources in tdelibs?

PS Found the sources, will probably take a look tomorrow.

Sounds reasonable, even though the only place I've encountered this bug is actually Konqueror. You do agree with the folder_red icon? I used this because I've seen it used for representing / in some other places. Could somebody please point me where to look for KMimeType sources in tdelibs? PS Found the sources, will probably take a look tomorrow.
Owner

Sounds reasonable, even though the only place I've encountered this bug is actually Konqueror.

You can try Open or Save dialog from Kate and go to the / folder. It does not display in red.

Yes, folder_red makes sense for root folder.

For mimetypes, you can start from the link in Slavek's comment, which will bring you to the file and line number of that function (tdeio/tdeio/kmimetype.cpp#L507)

> Sounds reasonable, even though the only place I've encountered this bug is actually Konqueror. You can try Open or Save dialog from Kate and go to the / folder. It does not display in red. Yes, folder_red makes sense for root folder. For mimetypes, you can start from the link in Slavek's comment, which will bring you to the file and line number of that function ([tdeio/tdeio/kmimetype.cpp#L507](https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/src/branch/master/tdeio/tdeio/kmimetype.cpp#L507))
blu.256 added PR/not-ok and removed PR/rfc labels 3 years ago
blu.256 closed this pull request 3 years ago
Poster
Collaborator

Superseded by PR tdelibs#129.

Superseded by PR [tdelibs#129](https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/129).
blu.256 deleted branch issue/1 3 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#192
Loading…
There is no content yet.