Issue #1: Konqueror shows "new file" icon on location bar for / folder
#192
Closed
blu.256
wants to merge 1 commits from issue/1
into master
pull from: issue/1
merge into: TDE:master
TDE:r14.1.x
TDE:master
TDE:fix/kxkb-450
TDE:feat/shutdownd-dialog-border
TDE:feat/whatever
TDE:feat/kdesktop
TDE:feat/layouts
TDE:issue/270/tdebase
TDE:r14.0.x
TDE:v3.5.13-sru
TDE:issue/227
TDE:fix/kicker-clock-build-dependency
TDE:feat/pkg-config
TDE:branding/kde_to_tde2
TDE:feat/fix-suspend-code
Reviewers
Request review
No reviewers
Labels
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label
GE/need-info
PR/keep-branch
PR/not-ok
PR/rfc
PR/update-trans
PR/wip
RS/R14.0.x
RS/R14.1.x
SL/critical
SL/major
SL/minor
SL/normal
SL/regression
SL/trivial
SL/wishlist
ST/duplicate
ST/invalid
ST/notourproblem
ST/rejected
ST/wontfix
ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: TDE/tdebase#192
Reference in new issue
There is no content yet.
Delete Branch 'issue/1'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
This is a little fix for Konqueror which makes it show the correct ("folder_red") icon for the root (/) directory.
For this to work you might have to clear Konqueror's icon cache, stored in file ~/.trinity/share/config/konq_history.
Comments and suggestions are welcome.
9db7e59337
to904ad624d6
3 years agoThe selected icon seems like an interesting idea (originally there was just an ordinary directory icon). Interesting challenge is also the possibility of closing the first issue. But it is a question whether the right should be started analyzing in the
KMimeType::iconForURL(...)
in tdelibs because the same case can also be reflected in other uses?I also think it would be better to fix this on the iconForUrl() method, because doing so would ensure consistency across various TDE applications. For example thinks of open/save dialogs used by most of the programs. Or dolphin and krusader file manager.
Sounds reasonable, even though the only place I've encountered this bug is actually Konqueror.
You do agree with the folder_red icon? I used this because I've seen it used for representing / in some other places.
Could somebody please point me where to look for KMimeType sources in tdelibs?
PS Found the sources, will probably take a look tomorrow.
You can try Open or Save dialog from Kate and go to the / folder. It does not display in red.
Yes, folder_red makes sense for root folder.
For mimetypes, you can start from the link in Slavek's comment, which will bring you to the file and line number of that function (tdeio/tdeio/kmimetype.cpp#L507)
Superseded by PR tdelibs#129.