Fixed FTBFS when building without tdehw but using HAL. #203

This fixes build with HAL on and tdehw off. Tested on wheezy. Please help testing on BSD or slackware.

For debian testing, you can use this this tde-packaging commit to removed the unwanted files from .install files for both tdelibs and tdebase and to add missing dependencies for HAL.

Because HAL port on FreeBSD was removed, it complicates testing. I would have to restore a HAL port from some older copy and test whether HAL can be built on FreeBSD 13.

Because HAL port on FreeBSD was removed, it complicates testing. I would have to restore a HAL port from some older copy and test whether HAL can be built on FreeBSD 13.

Tested in Wheezy was good. If test in Slackware from Greg is also good, I think we can skip testing in BSD, given than now HAL has been removed.

To my knowledge HAL is still available for NetBSD https://pkgsrc.se/sysutils/hal but no-one seems to have packaged TDE for this OS yet.

Isn't @obache building for NetBSD? Or is my memory wrong?

Isn't @obache building for NetBSD? Or is my memory wrong?

He might be building TDE through build scripts like Phillippe does on Arch.

It seems okay.

It seems okay.

Thanks Slavek. I will wait till Greg's test this weekend before merging. Will be good to see a test on a non Debian distro, just for extra feedback.

Rebased on latest master.

Build fine with HAL only, CDs are detected as well. Good job! 👍

If you want me to perform other tests (HAL related), now is the time 😉

Great, thanks for testing Greg! I will need to understand why here .iso images are not detected correctly and if that is a VM specific issue (works fine in bullseye with tdehw though).

If you have a chance to create a LUKS disk and see if you can unlock/mount/unmount/lock it using HAL it would be great. That would be the last test.

If you have a chance to create a LUKS disk and see if you can unlock/mount/unmount/lock it using HAL it would be great. That would be the last test.

Hi Greg, I tested in Wheezy and there is definitely more work to do for LUKS support using HAL. It is doing some of the work but parts are still missing. No need to test for the time being, it would simply fail.

I'll keep this install (on an old hdd) somewhere in case further testing is needed.

Regarding lusk support with HAL, who's going to make use of It? Does Dillos relies on HAL?

Regarding lusk support with HAL, who's going to make use of It? Does Dillos relies on HAL?

No idea, but it is more a matter of doing things right. As long as we want to provide HAL support, we should try to make it as complete as possible.

Fixed FTBFS when building without tdehw but using HAL. #203

Reviewers