TDE
/
tdebase
9
4
Fork 1
Code Issues 115 Pull Requests 10 Releases Wiki Activity
Labels Milestones

Updated after changes to tdehw lib related to device notificaitons. #219

Merged
MicheleC merged 2 commits from fix/rework-tdehw-notifications into master 3 years ago
Conversation 2 Commits 2 Files Changed 3
MicheleC commented 3 years ago
Owner

Needs TDE/tdelibs#144 for testing.

Needs TDE/tdelibs#144 for testing.
MicheleC added this to the R14.1.0 release milestone 3 years ago
MicheleC force-pushed fix/rework-tdehw-notifications from 6a82e398b6 to 014d93d59e 3 years ago
MicheleC commented 3 years ago
Poster
Owner

Updated to provide notifications also when a CD is inserted/removed.

Updated to provide notifications also when a CD is inserted/removed.
MicheleC requested review from SlavekB 3 years ago
MicheleC force-pushed fix/rework-tdehw-notifications from 014d93d59e to bb2ea23175 3 years ago
SlavekB added 1 commit 3 years ago
8665255c0c
hwdevicetray: Use the disk label for menu items, if available.
SlavekB approved these changes 3 years ago
SlavekB left a comment
Owner

It looks good, everything seems that it works as it should work.
I added a small commit that the disk label used in notifications is also used for menu items.

It looks good, everything seems that it works as it should work. I added a small commit that the disk label used in notifications is also used for menu items.
MicheleC merged commit 8665255c0c into master 3 years ago
MicheleC deleted branch fix/rework-tdehw-notifications 3 years ago
MicheleC commented 3 years ago
Poster
Owner

Thanks for testing and for the additional commit.

Thanks for testing and for the additional commit.

Reviewers

SlavekB approved these changes 3 years ago
The pull request has been merged as 8665255c0c.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Depends on
#144 tdehw lib: reworked device notifications to avoid repeated scanning of devices.
TDE/tdelibs
Reference: TDE/tdebase#219
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/rework-tdehw-notifications'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes