TDE
/
tdebase
9
4
Fork 1
Code Issues 115 Pull Requests 10 Releases Wiki Activity
Labels Milestones

Change libkonq/PLUGINS and libkonq/SERVICEMENUS to Markdown format #292

Merged
SlavekB merged 1 commits from issue/290/servicemenus-ntfix into master 2 years ago
Conversation 3 Commits 1 Files Changed 3
bobsmith commented 2 years ago
Collaborator

Signed-off-by: bobsmith bobsmith432@tutanota.com

Signed-off-by: bobsmith <bobsmith432@tutanota.com>
SlavekB requested changes 2 years ago
SlavekB left a comment
Owner

That's not good. It is desirable that the file is really use Markdown formatting – see the comment below.

At the same time, there is no good message in git commit. There should be stated what is the subject of the commit, but there is no point in providing a call for testing. This belongs to the Pull-Request comment.

A suitable git commit messages could be for example:

Change libkonq/SERVICEMENUS to Markdown format.
This resolves issue #290.
That's not good. It is desirable that the file is really use Markdown formatting – see the comment below. At the same time, there is no good message in git commit. There should be stated what is the subject of the commit, but there is no point in providing a call for testing. This belongs to the Pull-Request comment. A suitable git commit messages could be for example: ``` Change libkonq/SERVICEMENUS to Markdown format. This resolves issue #290. ```
libkonq/SERVICEMENUS.md Outdated
konqueror and kdesktop), without using the file associations.
This file has been converted to Markdown, in order to ensure compatibility with the Windows NT kernel
- bobsmith
SlavekB commented 2 years ago
Owner

It is unnecessary to insert such a comment into this file.

It should be more important to edit the file to use Markdown formatting. You can see that now it really does not look good – especially the part with the desktop file:
77fb786043/libkonq/SERVICEMENUS.md

It is unnecessary to insert such a comment into this file. It should be more important to edit the file to use Markdown formatting. You can see that now it really does not look good – especially the part with the desktop file: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/commit/77fb78604370e7292df5c443f6bdb37f2ce2a174/libkonq/SERVICEMENUS.md
bobsmith commented 2 years ago
Poster
Collaborator

So I'm using the Abricotine editor, and it looks just fine in that for some reason. I do agree I probably shouldn't have slipped in the comment.

So I'm using the Abricotine editor, and it looks just fine in that for some reason. I do agree I probably shouldn't have slipped in the comment.
MicheleC commented 2 years ago
Owner

You can adjust the commit with git commit --amend --no-edit and then use git push -f origin HEAD to update the code here.

You can adjust the commit with `git commit --amend --no-edit` and then use `git push -f origin HEAD` to update the code here.
SlavekB marked this conversation as resolved
MicheleC commented 2 years ago
Owner

@bobsmith
thanks for your first PR!! Slavek and I will share guidelines on what is good and not-so-good practice for commits, hope it will be useful.

@bobsmith thanks for your first PR!! Slavek and I will share guidelines on what is good and not-so-good practice for commits, hope it will be useful.
SlavekB force-pushed issue/290/servicemenus-ntfix from 77fb786043 to 2c9187584a 2 years ago
SlavekB commented 2 years ago
Owner

In order to move forward, I have made an editing of the SERVICEMENUS file to make use of Markdown formatting. At the same time, I also made a PLUGINS file formatting. See: 2c9187584a/libkonq/SERVICEMENUS.md and 2c9187584a/libkonq/PLUGINS.md

In order to move forward, I have made an editing of the `SERVICEMENUS` file to make use of Markdown formatting. At the same time, I also made a `PLUGINS` file formatting. See: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/commit/2c9187584a383dc0623ea7dba02b0612e0a1e3b4/libkonq/SERVICEMENUS.md and https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/commit/2c9187584a383dc0623ea7dba02b0612e0a1e3b4/libkonq/PLUGINS.md
SlavekB changed title from WIP: Should fix #290, but other Windows users please test to WIP: Change libkonq/PLUGINS and libkonq/SERVICEMENUS to Markdown format 2 years ago
MicheleC approved these changes 2 years ago
MicheleC left a comment
Owner

Looks good

Looks good
SlavekB changed title from WIP: Change libkonq/PLUGINS and libkonq/SERVICEMENUS to Markdown format to Change libkonq/PLUGINS and libkonq/SERVICEMENUS to Markdown format 2 years ago
SlavekB approved these changes 2 years ago
SlavekB left a comment
Owner

Formatting adjustments have been resolved, so nothing prevents merge.

Formatting adjustments have been resolved, so nothing prevents merge.
SlavekB merged commit 2c9187584a into master 2 years ago
SlavekB deleted branch issue/290/servicemenus-ntfix 2 years ago
SlavekB added this to the R14.0.13 release milestone 2 years ago
bobsmith commented 2 years ago
Poster
Collaborator

In order to move forward, I have made an editing of the SERVICEMENUS file to make use of Markdown formatting. At the same time, I also made a PLUGINS file formatting. See: 2c9187584a/libkonq/SERVICEMENUS.md and 2c9187584a/libkonq/PLUGINS.md

Thank you for this!

> In order to move forward, I have made an editing of the `SERVICEMENUS` file to make use of Markdown formatting. At the same time, I also made a `PLUGINS` file formatting. See: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/commit/2c9187584a383dc0623ea7dba02b0612e0a1e3b4/libkonq/SERVICEMENUS.md and https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/src/commit/2c9187584a383dc0623ea7dba02b0612e0a1e3b4/libkonq/PLUGINS.md Thank you for this!

Reviewers

MicheleC approved these changes 2 years ago
SlavekB approved these changes 2 years ago
The pull request has been merged as 2c9187584a.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.13 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#292
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'issue/290/servicemenus-ntfix'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes