WIP: Fix branding for kicker menu icons.
#51
Draft
Chris
wants to merge 1 commits from branding/kde_to_tde2
into master
pull from: branding/kde_to_tde2
merge into: TDE:master
TDE:r14.1.x
TDE:master
TDE:fix/kxkb-450
TDE:feat/shutdownd-dialog-border
TDE:feat/whatever
TDE:feat/kdesktop
TDE:feat/layouts
TDE:issue/270/tdebase
TDE:r14.0.x
TDE:v3.5.13-sru
TDE:issue/227
TDE:fix/kicker-clock-build-dependency
TDE:feat/pkg-config
TDE:feat/fix-suspend-code
Reviewers
Request review
No reviewers
Labels
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label
GE/need-info
PR/keep-branch
PR/not-ok
PR/rfc
PR/update-trans
PR/wip
RS/R14.0.x
RS/R14.1.x
SL/critical
SL/major
SL/minor
SL/normal
SL/regression
SL/trivial
SL/wishlist
ST/duplicate
ST/invalid
ST/notourproblem
ST/rejected
ST/wontfix
ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: TDE/tdebase#51
Reference in new issue
There is no content yet.
Delete Branch 'branding/kde_to_tde2'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
Needs investigation if:
That has some influence on users, if they update, because the old name is saved in some config.
If point one is the case, something in r14-xdg-update has to be added to make that change for users, after updating, so they don't notice anything of that change.
This prefix of the filenames is handled as translation in weblate. So it needs some translation commit too.
Signed-off-by: Chris xchrisx@uber.space
WIP: branding/kde_to_tde2to WIP: Fix branding for kicker menu icons 5 years agoWIP: Fix branding for kicker menu iconsto WIP: Fix branding for kicker menu icons. 5 years agoyes, this PR will need to be careful checked.
Why do we need translation update? We are only renaming files. Am I missing something?
Michele, I came about this one, because it was listed as translation in Weblate. After talking with Slavek, it turned out, that all this filenames are used as original strings for translations.
For example: https://mirror.git.trinitydesktop.org/weblate/translate/tdebase/kcmkicker/de/?checksum=7fd7f81552884ba7
So to fix the original string, I had to change the filenames. In the configuration dialog this one will be a translated label to select. But you are right about beeing careful. I discussed that one with Slavek already and we have to test it.
Hi Chris, I still don't understand. I searched all tde-i18n for "button_large_down" which is part of the name of one of the renamed files in this PR. There is no results from the search. So I think this PR has no strict relationship with translation files.
Still good to rename the files though, just need to make sure we rename in packaging repo too.
Hello Michele, I just looked for that again and yes, it seems that the string will be extracted without the "_" in the string. And only the first part. For example "KDE_Button" will be "KDE Button". You can look for the source in Weblate and you will see "tiles". It doesn't link to any source string, you can click at.
You can search for the above linked translation in your language and look the following entries. You will see:
"Blue Wood" (blue_wood) -> "Blaues Holz" (German)
I looked again and here is "large":
"https://mirror.git.trinitydesktop.org/weblate/translate/tdebase/kcmkicker/de/?q=Large&search=ftx&source=1&target=1&type=all&offset=2"
And same exist for "tiny". So most likely that strings are not extracted from the filename, because they exist anyway. That explains, why just the first part has to be used for that.
or
"Green Wood" (blue_wood) -> "Grünes Holz" (German)
The string will be extracted from the "_" and will be converted to all upper case for first char, it seems. And only the first part will be used. Maybe for "large" and "tiny" there are additional translations, which will be added to the translation string in the code.
@MicheleC, @Chris is correct. I'll take it from the other end. When you open the Control Center / Desktop / Panels / Appearance, you will see the Button Backgrounds group. There you will see lists with values like KDE Button, Blue Wood, Green Wood, etc.
This list is generated by searching for tiles files (specifically *_tiny_up.png), underscores are converted to spaces and the first letters of the words are capitalized – see lookandfeeltab_impl.cpp.
For the strings obtained in this way,
i18n()
is also used so that they can be localized. Therefore, in tde-i18n you won't find KDE_button_large_down, but KDE Button. See extracting strings in CMakeL10n. Therefore, after renaming the tiles files we need to update the template and translations 😺Ah ok, now I get the process and understand the various steps involved. Thanks for the explanation.
@SlavekB
are we going to do something with this PR or should we simply close it off? Chris has been MIA for long time. The file renaming is good but not a critical thing....