#51 WIP: Fix branding for kicker menu icons.

Open
Chris wants to merge 1 commits from branding/kde_to_tde2 into master
Chris commented 1 month ago

Needs investigation if:

1) That has some influence on users, if they update, because the old name is saved in some config.

2) If point one is the case, something in r14-xdg-update has to be added to make that change for users, after updating, so they don’t notice anything of that change.

This prefix of the filenames is handled as translation in weblate. So it needs some translation commit too.

Signed-off-by: Chris xchrisx@uber.space

Needs investigation if: 1) That has some influence on users, if they update, because the old name is saved in some config. 2) If point one is the case, something in r14-xdg-update has to be added to make that change for users, after updating, so they don't notice anything of that change. This prefix of the filenames is handled as translation in weblate. So it needs some translation commit too. Signed-off-by: Chris <xchrisx@uber.space>
Chris added the
PR/update-trans
label 1 month ago
Chris changed title from WIP: branding/kde_to_tde2 to WIP: Fix branding for kicker menu icons 1 month ago
Chris changed title from WIP: Fix branding for kicker menu icons to WIP: Fix branding for kicker menu icons. 1 month ago
Chris added the
PR/wip
label 1 month ago
MicheleC commented 1 month ago
Owner

yes, this PR will need to be careful checked.

Why do we need translation update? We are only renaming files. Am I missing something?

yes, this PR will need to be careful checked. Why do we need translation update? We are only renaming files. Am I missing something?
Chris commented 1 month ago
Poster

Michele, I came about this one, because it was listed as translation in Weblate. After talking with Slavek, it turned out, that all this filenames are used as original strings for translations.

For example: https://mirror.git.trinitydesktop.org/weblate/translate/tdebase/kcmkicker/de/?checksum=7fd7f81552884ba7

So to fix the original string, I had to change the filenames. In the configuration dialog this one will be a translated label to select. But you are right about beeing careful. I discussed that one with Slavek already and we have to test it.

Michele, I came about this one, because it was listed as translation in Weblate. After talking with Slavek, it turned out, that all this filenames are used as original strings for translations. For example: https://mirror.git.trinitydesktop.org/weblate/translate/tdebase/kcmkicker/de/?checksum=7fd7f81552884ba7 So to fix the original string, I had to change the filenames. In the configuration dialog this one will be a translated label to select. But you are right about beeing careful. I discussed that one with Slavek already and we have to test it.
MicheleC commented 1 month ago
Owner

Hi Chris, I still don’t understand. I searched all tde-i18n for “button_large_down” which is part of the name of one of the renamed files in this PR. There is no results from the search. So I think this PR has no strict relationship with translation files. Still good to rename the files though, just need to make sure we rename in packaging repo too.

Hi Chris, I still don't understand. I searched all tde-i18n for "button_large_down" which is part of the name of one of the renamed files in this PR. There is no results from the search. So I think this PR has no strict relationship with translation files. Still good to rename the files though, just need to make sure we rename in packaging repo too.
Chris commented 1 month ago
Poster

Hello Michele, I just looked for that again and yes, it seems that the string will be extracted without the “_” in the string. And only the first part. For example “KDE_Button” will be “KDE Button”. You can look for the source in Weblate and you will see “tiles”. It doesn’t link to any source string, you can click at.

You can search for the above linked translation in your language and look the following entries. You will see:

“Blue Wood” (blue_wood) -> “Blaues Holz” (German)

I looked again and here is “large”:

https://mirror.git.trinitydesktop.org/weblate/translate/tdebase/kcmkicker/de/?q=Large&search=ftx&source=1&target=1&type=all&offset=2

And same exist for “tiny”. So most likely that strings are not extracted from the filename, because they exist anyway. That explains, why just the first part has to be used for that.

or

“Green Wood” (blue_wood) -> “Grünes Holz” (German)

The string will be extracted from the “_” and will be converted to all upper case for first char, it seems. And only the first part will be used. Maybe for “large” and “tiny” there are additional translations, which will be added to the translation string in the code.

Hello Michele, I just looked for that again and yes, it seems that the string will be extracted *without* the "_" in the string. And only the first part. For example "KDE_Button" will be "KDE Button". You can look for the source in Weblate and you will see "tiles". It doesn't link to any source string, you can click at. You can search for the above linked translation in your language and look the following entries. You will see: "Blue Wood" (blue_wood) -> "Blaues Holz" (German) I looked again and here is "large": "https://mirror.git.trinitydesktop.org/weblate/translate/tdebase/kcmkicker/de/?q=Large&search=ftx&source=1&target=1&type=all&offset=2" And same exist for "tiny". So most likely that strings are not extracted from the filename, because they exist anyway. That explains, why just the first part has to be used for that. or "Green Wood" (blue_wood) -> "Grünes Holz" (German) The string will be extracted from the "_" and will be converted to all upper case for first char, it seems. And only the first part will be used. Maybe for "large" and "tiny" there are additional translations, which will be added to the translation string in the code.
SlavekB commented 1 month ago
Owner

@MicheleC, @Chris is correct. I’ll take it from the other end. When you open the Control Center / Desktop / Panels / Appearance, you will see the Button Backgrounds group. There you will see lists with values like KDE Button, Blue Wood, Green Wood, etc.

This list is generated by searching for tiles files (specifically *_tiny_up.png), underscores are converted to spaces and the first letters of the words are capitalized – see lookandfeeltab_impl.cpp.

For the strings obtained in this way, i18n() is also used so that they can be localized. Therefore, in tde-i18n you won’t find KDE_button_large_down, but KDE Button. See extracting strings in CMakeL10n. Therefore, after renaming the tiles files we need to update the template and translations :smiley_cat:

@MicheleC, @Chris is correct. I'll take it from the other end. When you open the Control Center / Desktop / Panels / Appearance, you will see the Button Backgrounds group. There you will see lists with values like KDE Button, Blue Wood, Green Wood, etc. This list is generated by searching for [tiles](src/branch/master/kicker/data/tiles) files (specifically *_tiny_up.png), underscores are converted to spaces and the first letters of the words are capitalized – see [lookandfeeltab_impl.cpp](src/branch/master/kcontrol/kicker/lookandfeeltab_impl.cpp#L307). For the strings obtained in this way, `i18n()` is also used so that they can be localized. Therefore, in tde-i18n you won't find *KDE_button_large_down*, but *KDE Button*. See extracting strings in [CMakeL10n](src/branch/master/kcontrol/kicker/CMakeL10n.txt). Therefore, after renaming the tiles files we need to update the template and translations :smiley_cat:
MicheleC commented 1 month ago
Owner

Ah ok, now I get the process and understand the various steps involved. Thanks for the explanation.

Ah ok, now I get the process and understand the various steps involved. Thanks for the explanation.
This pull request is marked as a work in progress. Remove the WIP: prefix from the title when it's ready
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.