TDE
/
tdebase
9
4
Fork 1
Code Issues 115 Pull Requests 10 Releases Wiki Activity
Labels Milestones

Replace Qt branding with TQt ones. #55

Merged
MicheleC merged 1 commits from branding/qt_to_tqt into master 5 years ago
Conversation 4 Commits 1 Files Changed 2
Chris commented 5 years ago
Collaborator

Also fixed branding of command line arguments.

Translation files updated in TDE/tde-i18n#23.

Signed-off-by: Chris xchrisx@uber.space

Also fixed branding of command line arguments. Translation files updated in TDE/tde-i18n#23. Signed-off-by: Chris <xchrisx@uber.space>
Chris added the PR/update-trans label 5 years ago
MicheleC commented 5 years ago
Owner

Regarding

-  TDECmdLineArgs *qtargs = TDECmdLineArgs::parsedArgs("qt");
+  TDECmdLineArgs *qtargs = TDECmdLineArgs::parsedArgs("tqt");

I am not sure we should do this rename at this point in time. In theory it is the correct renaming, but we need to do that as a system-wide fix rather than one application/package at a time. Probably better to open a TDE issue for this and then work on it as a whole.

Regarding ``` - TDECmdLineArgs *qtargs = TDECmdLineArgs::parsedArgs("qt"); + TDECmdLineArgs *qtargs = TDECmdLineArgs::parsedArgs("tqt"); ``` I am not sure we should do this rename at this point in time. In theory it is the correct renaming, but we need to do that as a system-wide fix rather than one application/package at a time. Probably better to open a TDE issue for this and then work on it as a whole.
Chris commented 5 years ago
Poster
Collaborator

Michele, you are right.

I will re-do that commit and open some summary issue for that.

That might be the better solution.

Michele, you are right. I will re-do that commit and open some summary issue for that. That might be the better solution.
MicheleC commented 5 years ago
Owner

Great, thanks a lot Chris. Let me know when this PR has been updated, then I will look into merging it.

Great, thanks a lot Chris. Let me know when this PR has been updated, then I will look into merging it.
Chris removed the PR/update-trans label 5 years ago
Chris commented 5 years ago
Poster
Collaborator

Renaming of the arguments was reverted. Messages about them not. Should be okay for mergeland now. 👍

Renaming of the arguments was reverted. Messages about them not. Should be okay for mergeland now. :+1:
Chris closed this pull request 5 years ago
MicheleC closed this pull request 5 years ago
MicheleC deleted branch branding/qt_to_tqt 5 years ago
MicheleC added this to the R14.0.7 release milestone 5 years ago
The pull request has been merged as 2d7de7cea4.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.7 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#55
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'branding/qt_to_tqt'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes