Labels Milestones

Add includes to UI files to resolve FTBFS #6

Merged

MicheleC merged 1 commits from feat/add-ui-includes into master 6 years ago

Conversation 1 Commits 1 Files Changed 59

SlavekB commented 6 years ago

Owner

Although I still have no idea why the FTBFS did not occur before, even though the includes were missing in the generated C++ source files, attached patch will fix this problem.

Although I still have no idea why the FTBFS did not occur before, even though the includes were missing in the generated C++ source files, attached patch will fix this problem.

MicheleC closed this pull request 6 years ago

MicheleC deleted branch feat/add-ui-includes 6 years ago

MicheleC commented 6 years ago

Owner

Looks good, no more FTBFS.

Merged and pushed upstream.

Looks good, no more FTBFS. Merged and pushed upstream.

MicheleC added this to the R14.0.6 release milestone 6 years ago

The pull request has been merged as 661ed658b7.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.0.6 release

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#6

Write Preview

Loading…

Cancel

Save

There is no content yet.