Streamline Color Profile module with the rest. #90

Merged
MicheleC merged 1 commits from fix/cprofiles into master 5 years ago
Chris commented 5 years ago
Collaborator

It's part of my attempt to clean up and polish things a bit. Before that change, it was obviously to me which applications were added by TDE (Tim) since the KDE3 fork. That was because they were bad integrated. The way now the color profiles module integrates much better and ICC color profiles are more or less just the(tm) color profiles, as I know. It's not needed to endless repeat that in all places it is about ICC profiles. We also don't name the power management module "Energy Star" or something like that. For simple users it's just about having color profiles, which is exactly the way other TCC modules are named like.

Please check your translations by chance.

By the way, I decided to go with singular for naming of the menu entry, because it seems some translations were already done that way too and other entries are named likewise. So I changed it that way also for the original (English) messages too.

It is still understandable that this configuration is about ICC profiles. At least from description and from file selection. So I think that should be fine this way.

Signed-off-by: Chris xchrisx@uber.space

It's part of my attempt to clean up and polish things a bit. Before that change, it was obviously to me which applications were added by TDE (Tim) since the KDE3 fork. That was because they were bad integrated. The way now the color profiles module integrates much better and ICC color profiles are more or less just the(tm) color profiles, as I know. It's not needed to endless repeat that in all places it is about ICC profiles. We also don't name the power management module "Energy Star" or something like that. For simple users it's just about having color profiles, which is exactly the way other TCC modules are named like. Please check your translations by chance. By the way, I decided to go with singular for naming of the menu entry, because it seems some translations were already done that way too and other entries are named likewise. So I changed it that way also for the original (English) messages too. It is still understandable that this configuration is about ICC profiles. At least from description and from file selection. So I think that should be fine this way. Signed-off-by: Chris <xchrisx@uber.space>
Ghost commented 5 years ago

The French translation in kcontrol/iccconfig/iccconfig.desktop is slightly off.
Can you please change it for:

Comment[fr]=Configurer le profil ICC des couleurs

The French translation in kcontrol/iccconfig/iccconfig.desktop is slightly off. Can you please change it for: Comment[fr]=Configurer le profil ICC des couleurs
Chris commented 5 years ago
Poster
Collaborator

Sure, I will do that. 👍

Sure, I will do that. :+1:
Chris commented 5 years ago
Poster
Collaborator

Do you want me to add also the missing keywords in FR?

Keywords=ICC;display;color;profile;

Do you want me to add also the missing keywords in FR? Keywords=ICC;display;color;profile;
Ghost commented 5 years ago

Thanks man!

Here is for the missing keywords:

Keywords[fr]=ICC;affichage;couleurs;profil;

Thanks man! Here is for the missing keywords: Keywords[fr]=ICC;affichage;couleurs;profil;
Chris commented 5 years ago
Poster
Collaborator

Thank you. I have added them. 👍

Thank you. I have added them. :+1:
MicheleC closed this pull request 5 years ago
MicheleC deleted branch fix/cprofiles 5 years ago
MicheleC added this to the R14.0.7 release milestone 5 years ago
The pull request has been merged as c06244f4f1.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebase#90
Loading…
There is no content yet.