Merge fixes for kalyptus that were made in tdelibs/dcopidlng #6

Manually merged
SlavekB merged 1 commits from fix/kalyptus-shortcomings into master 4 years ago
Owner

Because kalyptus, which has been fixed in tdelibs for dcopidlng, is also present in tdebindings (with some differences), it probably makes sense for the same fixes to be made in tdebindings as well.

  • includes may use quotation marks
  • argument types can contain multiple words
  • avoid use long, short, int or char type as the argument name
  • avoid use type as the argument name if the const qualifier is used
  • use long notation of int types
  • the arguments can be nameless
  • return types can have qualifiers
  • do not warn on inherit of the DCOPObject and TQObject classes
  • the documentation comment does not have to end on a separate line
  • do not skip an empty class if it is declared with K_DCOP
Because kalyptus, which has been fixed in tdelibs for dcopidlng, is also present in tdebindings (with some differences), it probably makes sense for the same fixes to be made in tdebindings as well. + includes may use quotation marks + argument types can contain multiple words + avoid use long, short, int or char type as the argument name + avoid use type as the argument name if the const qualifier is used + use long notation of int types + the arguments can be nameless + return types can have qualifiers + do not warn on inherit of the DCOPObject and TQObject classes + the documentation comment does not have to end on a separate line + do not skip an empty class if it is declared with K_DCOP
Owner

Looks good to me. We should probably consider removing kalyptus from tdebindings and use the one coming from tdelibs in future, but that can be low priority....

EDIT: kalyptus in tdebingings has a lot more files, so probably it extends the functionality in tdelibs

Looks good to me. We should probably consider removing kalyptus from tdebindings and use the one coming from tdelibs in future, but that can be low priority.... EDIT: kalyptus in tdebingings has a lot more files, so probably it extends the functionality in tdelibs
Owner

libtqt-perl should also need the same fixes

libtqt-perl should also need the same fixes
Poster
Owner

libtqt-perl should also need the same fixes

Good reminder, thank you!

> libtqt-perl should also need the same fixes Good reminder, thank you!
Poster
Owner

Looks good to me. We should probably consider removing kalyptus from tdebindings and use the one coming from tdelibs in future, but that can be low priority....

EDIT: kalyptus in tdebingings has a lot more files, so probably it extends the functionality in tdelibs

Yes, the version in tdelibs probably contains only the parts necessary for dcopidlng. The instance in tdebindings, among other files, also contains some differences in the code. So there would be good to figure out the differences and unify all instances of kalyptus. However, we agree that it has a low priority.

> Looks good to me. We should probably consider removing kalyptus from tdebindings and use the one coming from tdelibs in future, but that can be low priority.... > > EDIT: kalyptus in tdebingings has a lot more files, so probably it extends the functionality in tdelibs Yes, the version in tdelibs probably contains only the parts necessary for dcopidlng. The instance in tdebindings, among other files, also contains some differences in the code. So there would be good to figure out the differences and unify all instances of kalyptus. However, we agree that it has a low priority.
SlavekB closed this pull request 4 years ago
SlavekB deleted branch fix/kalyptus-shortcomings 4 years ago
SlavekB added this to the R14.0.9 release milestone 4 years ago
The pull request has been manually merged as ee9b1e7dc5.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdebindings#6
Loading…
There is no content yet.