TDE
/
tdeedu
6
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
Labels Milestones

Fix FTBFS on Fedora 34 #14

Merged
MicheleC merged 1 commits from ftbfs/fedora34 into master 3 years ago
Conversation 0 Commits 1 Files Changed 1
Francois commented 3 years ago
Collaborator

/tmp/BUILD.fc34.x86_64/trinity-tdeedu-14.0.10/kiten/learn.cpp:804:16: required from here
/usr/include/c++/11/bits/stl_tree.h:770:15: error: static assertion failed: comparison object must be invocable as const
770 | is_invocable_v<const _Compare&, const _Key&, const _Key&>,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/11/bits/stl_tree.h:770:15: note: ‘std::is_invocable_v<const Learn::scoreCompare&, const TQListViewItem* const&, const TQListViewItem* const&>’ evaluates to false

/tmp/BUILD.fc34.x86_64/trinity-tdeedu-14.0.10/kiten/learn.cpp:804:16: required from here /usr/include/c++/11/bits/stl_tree.h:770:15: error: static assertion failed: comparison object must be invocable as const 770 | is_invocable_v<const _Compare&, const _Key&, const _Key&>, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/c++/11/bits/stl_tree.h:770:15: note: ‘std::is_invocable_v<const Learn::scoreCompare&, const TQListViewItem* const&, const TQListViewItem* const&>’ evaluates to false
Francois added 1 commit 3 years ago
97a8074efb Fix FTBFS on Fedora 34
MicheleC requested changes 3 years ago
MicheleC left a comment
Owner

Could you please adjust as commented? Other than that, the change looks good.

Could you please adjust as commented? Other than that, the change looks good.
kiten/learn.cpp Outdated
{
bool operator()(const TQListViewItem* v1, const TQListViewItem* v2)
{
const {
MicheleC commented 3 years ago
Owner

It looks good but I would move 'const' to the end of the previous line, it is much clearer that the 'operator()' is a const member.

It looks good but I would move 'const' to the end of the previous line, it is much clearer that the 'operator()' is a const member.
MicheleC marked this conversation as resolved
Francois force-pushed ftbfs/fedora34 from 97a8074efb to 0cb84fb903 3 years ago
MicheleC approved these changes 3 years ago
MicheleC left a comment
Owner

Great, thanks!

Great, thanks!
MicheleC merged commit 0cb84fb903 into master 3 years ago
MicheleC deleted branch ftbfs/fedora34 3 years ago
MicheleC added this to the R14.0.11 release milestone 3 years ago

Reviewers

MicheleC approved these changes 3 years ago
The pull request has been merged as 0cb84fb903.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.11 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdeedu#14
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ftbfs/fedora34'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes