TDE
/
tdeedu
6
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
Labels Milestones

Fix boost_python library detection on CentOS 8 #9

Closed
Francois wants to merge 1 commits from <deleted>:r14.0.x into r14.0.x
Conversation 2 Commits 1 Files Changed 1
Francois commented 4 years ago
Collaborator

On CentOS 8, the boost-python3 library is '/usr/lib64/libboost_python3.so.1.66.0'.
Notice that only the minor python version is present (3).

On CentOS 8, the boost-python3 library is '/usr/lib64/libboost_python3.so.1.66.0'. Notice that only the minor python version is present (3).
SlavekB commented 4 years ago
Owner

François, that looks good. Here are some notes:

  1. Because the same problem applies to the master, PR should be against the master.
  2. Because the final tarball and deb packages for tdeedu are already built, it is too late to pick this patch to R14.0.8. Therefore, for R14.0.8, leave the patch in your tde-packaging for now.
  3. Instead of the PR created on the fork, you can push it into the branch on the main repository.

I apologize for the inconvenience.

François, that looks good. Here are some notes: 1. Because the same problem applies to the master, PR should be against the master. 2. Because the final tarball and deb packages for tdeedu are already built, it is too late to pick this patch to R14.0.8. Therefore, for R14.0.8, leave the patch in your tde-packaging for now. 3. Instead of the PR created on the fork, you can push it into the branch on the main repository. I apologize for the inconvenience.
SlavekB commented 4 years ago
Owner

Since there was no response, I used commit on the master branch and did a backport to r14.0.x branch. As a result, the subject of this pull request is processed and can therefore be closed without merging.

Since there was no response, I used commit on the master branch and did a backport to r14.0.x branch. As a result, the subject of this pull request is processed and can therefore be closed without merging.
SlavekB closed this pull request 4 years ago
SlavekB added this to the R14.0.9 release milestone 4 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.9 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdeedu#9
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '<deleted>:r14.0.x'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes