Thanks Denis, looks interesting. Nice to see other people proposing new code and applications!
> This answers bug [1049](https://bugs.trinitydesktop.org/show_bug.cgi?id=1049) I guess.
It seems unrelated to bug 1049.
Thanks Denis, looks interesting. Nice to see other people proposing new code and applications!
@denis I had a super quick look. Would you be interested into making it a proper TDE application instead of a TQApplication? So that it would fit even more naturally into TDE? 😄
@denis I had a super quick look. Would you be interested into making it a proper TDE application instead of a TQApplication? So that it would fit even more naturally into TDE? :smile:
Correction, it would solve bug 1049 as pointed out by Greg. Sorry for the noise :-(
> > This answers bug [1049](https://bugs.trinitydesktop.org/show_bug.cgi?id=1049) I guess.
>
> It seems unrelated to bug 1049.
>
Correction, it would solve bug 1049 as pointed out by Greg. Sorry for the noise :-(
I did a quick local build test, it builds fine and it works!
Here is a list of few improvements to do in future, as reference (thanks Greg too!)
prepare tde-packaging related files for DEB (MicheleC or SlavekB)
merge code (MicheleC or SlavekB)
convert cmake stuff to standard TDE cmake stuff (Greg)
drop qt4 stuff (whoever)
add .desktop file (Greg?)
convert to TDE app (either Denis or MicheleC, in the long term)
Anything else I missed?
I did a quick local build test, it builds fine and it works!<br>
Here is a list of few improvements to do in future, as reference (thanks Greg too!)
1. prepare tde-packaging related files for DEB (MicheleC or SlavekB)
2. merge code (MicheleC or SlavekB)
3. convert cmake stuff to standard TDE cmake stuff (Greg)
4. drop qt4 stuff (whoever)
5. add .desktop file (Greg?)
6. convert to TDE app (either Denis or MicheleC, in the long term)
Anything else I missed?
I have discussed with Slavek and Greg. For the time being we will not merge this and chess (#6) application until R14.0.8 is released. After that we will decide whether to merge for R14.1.0 or in subsequent R14.1.x releases, since we want to prioritize R14.1.0 and make sure we release before the end of the year.
In the meantime, feel free to work on the required code and update these 2 PRs so that the code comes closer to the TDE standard (See points in previous comments).
I will mark the PR as WIP for the time being.
@denis thanks for making these apps available, please be patient and sooner or later they will be merged 😄
I have discussed with Slavek and Greg. For the time being we will not merge this and chess (#6) application until R14.0.8 is released. After that we will decide whether to merge for R14.1.0 or in subsequent R14.1.x releases, since we want to prioritize R14.1.0 and make sure we release before the end of the year.
In the meantime, feel free to work on the required code and update these 2 PRs so that the code comes closer to the TDE standard (See points in previous comments).
I will mark the PR as WIP for the time being.
@denis thanks for making these apps available, please be patient and sooner or later they will be merged :smile:
MicheleC
changed title from fifteen puzzle game to WIP: fifteen puzzle game4 years ago
I have removed the WIP status of this PR, please test, let me know if It's good enough for a basic application.
I wished I could add a man page but I noticed that there is none for the other games in the module (tdegames), so I prefer handling this in an other branch/PR.
I'd also like to add icons (https://commons.wikimedia.org/wiki/File:15-puzzle.svg) this one is Public Domain released.
It just fits the bill in my view but I've been strugling to remove the border of the image (gimp stuff) as a result this will be done in an other PR (when I'm done if any).
I have removed the WIP status of this PR, please test, let me know if It's good enough for a basic application.
I wished I could add a man page but I noticed that there is none for the other games in the module (tdegames), so I prefer handling this in an other branch/PR.
I'd also like to add icons (https://commons.wikimedia.org/wiki/File:15-puzzle.svg) this one is Public Domain released.
It just fits the bill in my view but I've been strugling to remove the border of the image (gimp stuff) as a result this will be done in an other PR (when I'm done if any).
Ghost
changed title from WIP: fifteen puzzle game to fifteen puzzle game3 years ago
@MicheleC I've added icons, passed the app name to lower case, made the copyright clear according to Denis's comment above.
All yours to test/comment. 😉
Man page in an other branch (I wish to add all the man pages you've got in the Deb packaging).
@MicheleC I've added icons, passed the app name to lower case, made the copyright clear according to Denis's comment above.
All yours to test/comment. :wink:
Man page in an other branch (I wish to add all the man pages you've got in the Deb packaging).
The first 10 lines of comments don't say much other than the author. We could make a single line. The rest is no use and waste time to read and realize they are no use.
// Author: Denis Kozadaev (denis@tambov.ru)
Same applies to the other source files.
The first 10 lines of comments don't say much other than the author. We could make a single line. The rest is no use and waste time to read and realize they are no use.
```
// Author: Denis Kozadaev (denis@tambov.ru)
```
Same applies to the other source files.
Most of the comments have already been made by @MicheleC
For me, a note that a commit with renaming to lowercase could be a squashed with a commit for a change to a TDE application, so that there is no unnecessarily double renaming within a single PR.
Most of the comments have already been made by @MicheleC
For me, a note that a commit with renaming to lowercase could be a squashed with a commit for a change to a TDE application, so that there is no unnecessarily double renaming within a single PR.
MicheleC
A simple fifteen puzzle game
Signed-off-by: Denis Kozadaev denis@dilos.org
This answers bug 1049 I guess.
I did not convert anything from an existing code.
The program was written by a FreeBSD porter query long time ago
and I offer it to you
It seems unrelated to bug 1049.
Thanks Denis, looks interesting. Nice to see other people proposing new code and applications!
@denis I had a super quick look. Would you be interested into making it a proper TDE application instead of a TQApplication? So that it would fit even more naturally into TDE? 😄
Correction, it would solve bug 1049 as pointed out by Greg. Sorry for the noise :-(
It is possible but in some time because I don't know KDE/TDE API at all.
ok, no problem at all 👍
I did a quick local build test, it builds fine and it works!
Here is a list of few improvements to do in future, as reference (thanks Greg too!)
Anything else I missed?
I have discussed with Slavek and Greg. For the time being we will not merge this and chess (#6) application until R14.0.8 is released. After that we will decide whether to merge for R14.1.0 or in subsequent R14.1.x releases, since we want to prioritize R14.1.0 and make sure we release before the end of the year.
In the meantime, feel free to work on the required code and update these 2 PRs so that the code comes closer to the TDE standard (See points in previous comments).
I will mark the PR as WIP for the time being.
@denis thanks for making these apps available, please be patient and sooner or later they will be merged 😄
fifteen puzzle gameto WIP: fifteen puzzle game 4 years agoFor those interrested in the history of those kind of puzzles: https://en.wikipedia.org/wiki/15_puzzle
I have removed the WIP status of this PR, please test, let me know if It's good enough for a basic application.
I wished I could add a man page but I noticed that there is none for the other games in the module (tdegames), so I prefer handling this in an other branch/PR.
I'd also like to add icons (https://commons.wikimedia.org/wiki/File:15-puzzle.svg) this one is Public Domain released.
It just fits the bill in my view but I've been strugling to remove the border of the image (gimp stuff) as a result this will be done in an other PR (when I'm done if any).
WIP: fifteen puzzle gameto fifteen puzzle game 3 years ago@denis What is the copyright for q15 source if I may ask? GPL, MIT, BSD...
The code was relicensed from BSD to GPL when I pushed it to TDE.
@MicheleC I've added icons, passed the app name to lower case, made the copyright clear according to Denis's comment above.
All yours to test/comment. 😉
Man page in an other branch (I wish to add all the man pages you've got in the Deb packaging).
Few things to adjust here and there, as commented. Nothing major, mostly good practices.
option( BUILD_KTUBERLING "Build ktuberling" ${BUILD_ALL} )option( BUILD_LSKAT "Build lskat" ${BUILD_ALL} )option( BUILD_TWIN4 "Build twin4" ${BUILD_ALL} )option( BUILD_FIFTEEN "Build TDEFifteenPieces" ${BUILD_ALL} )The option and the name don't match, so it is different from the other options. Would be better to have consistency. Like BUILD_FIFTEENPIECES.
BUILD_FIFTEENPIECES sounds good to me.
##### Import libtdegames##### All these games require libtdegamesDoes TDEFifteenPieces requires libtdegames? Just asking :-)
##### iconstde_install_icons( TDEFifteenPieces )Icon names should be lower case if possible
###### other datatde_create_translated_desktop( TDEFifteenPieces.desktop )the desktop file should be in lower cases like other games
GenericName=puzzle-solving gameExec=tdefifteenpiecesComment=sliding puzzle with one missing tileIcon=TDEFifteenPiecesIcon names should be lower case if possible
/*The first 10 lines of comments don't say much other than the author. We could make a single line. The rest is no use and waste time to read and realize they are no use.
Same applies to the other source files.
Most of the comments have already been made by @MicheleC
For me, a note that a commit with renaming to lowercase could be a squashed with a commit for a change to a TDE application, so that there is no unnecessarily double renaming within a single PR.
Name=TDEFifteenPiecesGenericName=puzzle-solving gameExec=tdefifteenpiecesComment=sliding puzzle with one missing tileGenericName and Comment could start with the first capital letter.
Oh yes, I also spotted that. I must have forgot to "save" the comment I made. Thanks Slavek!
Looks good to me now. Ok to merge?
LGTM 👍
dd4e287280into master 3 years agoReviewers
dd4e287280.