TDE
/
tdegames
6
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity
Labels Milestones

Small rearrangement of libtdegames headers #7

Merged
MicheleC merged 1 commits from :rearrange-kgame-headers into master 4 years ago
Conversation 3 Commits 1 Files Changed 13
Fat-Zer commented 4 years ago
Collaborator

Move kgame dialog headers to a dedicated subdir to make installed
includes match source code layout. This will make linking of games
to an installed instance of libtdegames library more straightforward.

Signed-off-by: Alexander Golubev fatzer2@gmail.com

Move kgame dialog headers to a dedicated subdir to make installed includes match source code layout. This will make linking of games to an installed instance of libtdegames library more straightforward. Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
MicheleC closed this pull request 4 years ago
MicheleC commented 4 years ago
Owner

PR is good, thanks! Will backport to R14.0.9 when the windows open. Will keep the PR open till then.

PR is good, thanks! Will backport to R14.0.9 when the windows open. Will keep the PR open till then.
MicheleC deleted branch rearrange-kgame-headers 4 years ago
MicheleC added this to the R14.0.9 release milestone 4 years ago
MicheleC commented 4 years ago
Owner

I have to correct myself. This PR caused FTBFS, my bad for not testing a build before merging. Rectified in commit f1f0991.

I have to correct myself. This PR caused FTBFS, my bad for not testing a build before merging. Rectified in commit f1f0991.
MicheleC commented 4 years ago
Owner

Commits backported to R14.0.9.

Commits backported to R14.0.9.
The pull request has been merged as a94a863f93.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.9 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdegames#7
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch ':rearrange-kgame-headers'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes