#28 poppler-tqt: failed with poppler>=20.12.0

Open
opened 3 months ago by obache · 2 comments
obache commented 3 months ago
Collaborator

Basic information

  • TDE version: R14.0.9
  • Distribution: N/A
  • Hardware: N/A

Description

poppler-tqt will be failed to build in HAVE_SPLASH parts.

HAVE_SPLASH is not defined in tdegraphics build.

poppler-20.12.0 start to define HAVE_SPLASH in installed poppler-config.h
instead of buid tree config.h.

current HAVE_SPLASH parts should be based on older poppler-qt implementation.
HAVE_SPLASH parts should be catched up to recent poppler update.

Steps to reproduce

  1. install poppler-20.12.0 or later
  2. build tdegraphics with -DWITH_PDF:BOOL=ON

or you can see build failure if you have older poppler but with splash backend,
put #define HAVE_SPLASH 1 in config.h.cmake.

Consideration

If HAVE_SPLASH support is useful for tdegraphics, it should be detected and
ennabled even with poppler<20.12.0.
If not, maybe such parts can be removed safely.

<!-- This is a comment. Please fill in the required fields below. The comments provide instructions on how to do so. Note: You do not need to remove comments. --> ## Basic information - TDE version: R14.0.9 - Distribution: N/A - Hardware: N/A <!-- Use SL/* labels to set the severity level. Please do not set a milestone. --> ## Description poppler-tqt will be failed to build in `HAVE_SPLASH` parts. `HAVE_SPLASH` is not defined in tdegraphics build. poppler-20.12.0 start to define `HAVE_SPLASH` in installed `poppler-config.h` instead of buid tree `config.h`. current `HAVE_SPLASH` parts should be based on older poppler-qt implementation. `HAVE_SPLASH` parts should be catched up to recent poppler update. ## Steps to reproduce 1. install poppler-20.12.0 or later 2. build tdegraphics with -DWITH_PDF:BOOL=ON or you can see build failure if you have older poppler but with `splash` backend, put `#define HAVE_SPLASH 1` in config.h.cmake. ## Consideration If `HAVE_SPLASH` support is useful for tdegraphics, it should be detected and ennabled even with `poppler<20.12.0`. If not, maybe such parts can be removed safely.
SlavekB commented 3 months ago
Owner

Thanks for analyzing the issue. I looked in more detail at what that meant. Removing the HAVE_SPLASH code would seem to limit the future use of this library.

For example, I was hoping that poppler-tqt we could use in KPDF to replace existing code coming from xpdf. But removing the HAVE_SPLASH code would probably rule out such a possibility.

As a more sensible way, it seems that we should detect and enable HAVE_SPLASH also for older versions of the poppler and solve problems with its build – that is, the problem with constant changes to the poppler library API.

Thanks for analyzing the issue. I looked in more detail at what that meant. Removing the `HAVE_SPLASH` code would seem to limit the future use of this library. For example, I was hoping that `poppler-tqt` we could use in KPDF to replace existing code coming from xpdf. But removing the `HAVE_SPLASH` code would probably rule out such a possibility. As a more sensible way, it seems that we should detect and enable `HAVE_SPLASH` also for older versions of the poppler and solve problems with its build – that is, the problem with constant changes to the poppler library API.
Owner

As a more sensible way, it seems that we should detect and enable HAVE_SPLASH also for older versions of the poppler and solve problems with its build – that is, the problem with constant changes to the poppler library API.

I agree, that sounds more sensible.

> As a more sensible way, it seems that we should detect and enable `HAVE_SPLASH` also for older versions of the poppler and solve problems with its build – that is, the problem with constant changes to the poppler library API. I agree, that sounds more sensible.
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.