KPDF: Some fixes for cover page mode #30
Merged
MicheleC
merged 1 commits from feat/kpdf-coverpage-fixes
into master
3 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/kpdf-coverpage-fixes'
Deleting a branch is permanent. It CANNOT be undone. Continue?
1-page shift is now taken into account for size pages.
Before this change, the last page of a document with an even count of
pages would have zero height and be displayed 'floating' over the page
above it.
Improved code readability by using a variable to store the result of
the cover page mode check.
Signed-off-by: Mavridis Philippe mavridisf@gmail.com
Some fixes for cover page modeto KPDF: Some fixes for cover page mode 3 years agoIt looks good, however, there is one place where there is possible minor adjustment.
// so we can place widgets 'centered in virtual cells'.
int nCols = KpdfSettings::viewColumns(),
nRows = (int)ceil( (float)pageCount / (float)nCols ),
int pageShift = ( KpdfSettings::viewColumns() == 2 && KpdfSettings::viewCoverPage() ) ? 1 : 0,
It looks like there is also a place where the
coverPageMode
variable could be used.Yes indeed, just changed it.
Looks good Philippe. Could you squash your commits into one before we merge?
Yes, of course. Give me a moment
4fc5ba54be
to08380de42c
3 years agoDone!
08380de42c
into master 3 years agoThanks!
08380de42c
.