TDE
/
tdegraphics
8
0
Fork 0
Code Issues 9 Pull Requests 1 Releases Wiki Activity
Labels Milestones
New Issue

poppler-tqt ftbfs on fedora 35 / poppler 21.08.0 #34

Closed
opened 3 years ago by Francois · 4 comments
Francois commented 3 years ago
Collaborator

Basic information

  • TDE version: 14.0.11~pre12+ca22775e
  • Distribution: Fedora 35
  • Hardware: amd64

Description

FTBFS on Fedora 35, certainly due to changes in poppler library.
poppler version: 21.08.0

/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp:283:35: error: cannot convert 'const char*' to 'const GooString*'

Steps to reproduce

build

Screenshots

[ 19%] Building CXX object tdefile-plugins/dependencies/poppler-tqt/CMakeFiles/poppler-tqt-shared.dir/poppler-document.cpp.o
cd "/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build/tdefile-plugins/dependencies/poppler-tqt" && /usr/lib64/ccache/g++ -DHAVE_CONFIG_H -Dpoppler_tqt_shared_EXPORTS -I"/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build/tdefile-plugins/dependencies/poppler-tqt" -I"/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build" -I/opt/trinity/include/tde -I/usr/include/tqt3 -I/usr/include/tqt -I"/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt" -I/usr/include/poppler -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdebug-prefix-map=/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e=. -fmacro-prefix-map=/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e=.  -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -I/usr/include/tqt3 -I/usr/include/tqt -include tqt.h -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -DNDEBUG -fPIC -MD -MT tdefile-plugins/dependencies/poppler-tqt/CMakeFiles/poppler-tqt-shared.dir/poppler-document.cpp.o -MF CMakeFiles/poppler-tqt-shared.dir/poppler-document.cpp.o.d -o CMakeFiles/poppler-tqt-shared.dir/poppler-document.cpp.o -c "/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp"
/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp: In member function 'bool Poppler::Document::scanForFonts(int, TQValueList<Poppler::FontInfo>*) const':
/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp:150:22: warning: comparison of integer expressions of different signedness: 'int' and 'std::vector<FontInfo*>::size_type' {aka 'long unsigned int'} [-Wsign-compare]
  150 |   for ( int i = 0; i < FONTS_LIST_LENGTH(items); ++i ) {
/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp: In member function 'TQDateTime Poppler::Document::getDate(const TQString&) const':
/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp:283:35: error: cannot convert 'const char*' to 'const GooString*'
  283 |     if ( parseDateString( s.latin1(), &year, &mon, &day, &hour, &min, &sec, &tz, &tz_hour, &tz_minute ) )
      |                           ~~~~~~~~^~
      |                                   |
      |                                   const char*
In file included from /tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp:33:
/usr/include/poppler/DateInfo.h:31:62: note:   initializing argument 1 of 'bool parseDateString(const GooString*, int*, int*, int*, int*, int*, int*, char*, int*, int*)'
   31 | bool POPPLER_PRIVATE_EXPORT parseDateString(const GooString *date, int *year, int *month, int *day, int *hour, int *minute, int *second, char *tz, int *tzHour, int *tzMinute);
      |                                             ~~~~~~~~~~~~~~~~~^~~~
make[3]: *** [tdefile-plugins/dependencies/poppler-tqt/CMakeFiles/poppler-tqt-shared.dir/build.make:79: tdefile-plugins/dependencies/poppler-tqt/CMakeFiles/poppler-tqt-shared.dir/poppler-document.cpp.o] Error 1
make[3]: Leaving directory '/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build'
make[2]: *** [CMakeFiles/Makefile2:4143: tdefile-plugins/dependencies/poppler-tqt/CMakeFiles/poppler-tqt-shared.dir/all] Error 2
make[2]: Leaving directory '/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build'
make[1]: *** [Makefile:139: all] Error 2
make[1]: Leaving directory '/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build'
error: Bad exit status from /tmp/rpm-tmp.RhvAmk (%build)
<!-- This is a comment. Please fill in the required fields below. The comments provide instructions on how to do so. Note: You do not need to remove comments. --> ## Basic information - TDE version: 14.0.11~pre12+ca22775e - Distribution: Fedora 35 - Hardware: amd64 <!-- Use SL/* labels to set the severity level. Please do not set a milestone. --> ## Description FTBFS on Fedora 35, certainly due to changes in poppler library. poppler version: 21.08.0 /tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp:283:35: error: cannot convert 'const char*' to 'const GooString*' ## Steps to reproduce build ## Screenshots ``` [ 19%] Building CXX object tdefile-plugins/dependencies/poppler-tqt/CMakeFiles/poppler-tqt-shared.dir/poppler-document.cpp.o cd "/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build/tdefile-plugins/dependencies/poppler-tqt" && /usr/lib64/ccache/g++ -DHAVE_CONFIG_H -Dpoppler_tqt_shared_EXPORTS -I"/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build/tdefile-plugins/dependencies/poppler-tqt" -I"/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build" -I/opt/trinity/include/tde -I/usr/include/tqt3 -I/usr/include/tqt -I"/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt" -I/usr/include/poppler -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdebug-prefix-map=/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e=. -fmacro-prefix-map=/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e=. -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -I/usr/include/tqt3 -I/usr/include/tqt -include tqt.h -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -DNDEBUG -fPIC -MD -MT tdefile-plugins/dependencies/poppler-tqt/CMakeFiles/poppler-tqt-shared.dir/poppler-document.cpp.o -MF CMakeFiles/poppler-tqt-shared.dir/poppler-document.cpp.o.d -o CMakeFiles/poppler-tqt-shared.dir/poppler-document.cpp.o -c "/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp" /tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp: In member function 'bool Poppler::Document::scanForFonts(int, TQValueList<Poppler::FontInfo>*) const': /tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp:150:22: warning: comparison of integer expressions of different signedness: 'int' and 'std::vector<FontInfo*>::size_type' {aka 'long unsigned int'} [-Wsign-compare] 150 | for ( int i = 0; i < FONTS_LIST_LENGTH(items); ++i ) { /tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp: In member function 'TQDateTime Poppler::Document::getDate(const TQString&) const': /tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp:283:35: error: cannot convert 'const char*' to 'const GooString*' 283 | if ( parseDateString( s.latin1(), &year, &mon, &day, &hour, &min, &sec, &tz, &tz_hour, &tz_minute ) ) | ~~~~~~~~^~ | | | const char* In file included from /tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/tdefile-plugins/dependencies/poppler-tqt/poppler-document.cpp:33: /usr/include/poppler/DateInfo.h:31:62: note: initializing argument 1 of 'bool parseDateString(const GooString*, int*, int*, int*, int*, int*, int*, char*, int*, int*)' 31 | bool POPPLER_PRIVATE_EXPORT parseDateString(const GooString *date, int *year, int *month, int *day, int *hour, int *minute, int *second, char *tz, int *tzHour, int *tzMinute); | ~~~~~~~~~~~~~~~~~^~~~ make[3]: *** [tdefile-plugins/dependencies/poppler-tqt/CMakeFiles/poppler-tqt-shared.dir/build.make:79: tdefile-plugins/dependencies/poppler-tqt/CMakeFiles/poppler-tqt-shared.dir/poppler-document.cpp.o] Error 1 make[3]: Leaving directory '/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build' make[2]: *** [CMakeFiles/Makefile2:4143: tdefile-plugins/dependencies/poppler-tqt/CMakeFiles/poppler-tqt-shared.dir/all] Error 2 make[2]: Leaving directory '/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build' make[1]: *** [Makefile:139: all] Error 2 make[1]: Leaving directory '/tmp/BUILD.fc35.x86_64/trinity-tdegraphics-14.0.11~pre12+ca22775e/build' error: Bad exit status from /tmp/rpm-tmp.RhvAmk (%build) ```
Ray-V commented 3 years ago
Collaborator

I'm getting this error for a 14.0.x tdegraphics build with poppler 21.09.0

DateInfo.h line 31 changed in poppler 21.08.0 from this 21.07.0 source [same as 21.06.1]

bool POPPLER_PRIVATE_EXPORT parseDateString(const char *string, int *year, int *month, int *day, int *hour, int *minute, int *second, char *tz, int *tzHour, int *tzMinute);

I don't have a 21.07.0 package to test the build, but tdegraphics builds ok with poppler 21.06.1

If it's any help, this is the culpritcommit

I'm getting this error for a 14.0.x tdegraphics build with poppler 21.09.0 DateInfo.h line 31 changed in poppler 21.08.0 from this 21.07.0 source [same as 21.06.1] ``` bool POPPLER_PRIVATE_EXPORT parseDateString(const char *string, int *year, int *month, int *day, int *hour, int *minute, int *second, char *tz, int *tzHour, int *tzMinute); ``` I don't have a 21.07.0 package to test the build, but tdegraphics builds ok with poppler 21.06.1 If it's any help, this is the [<strike>culprit</strike>commit](https://cgit.freedesktop.org/poppler/poppler/commit/?id=2636e51212b99359cc940b806d645a9e43c33d74)
Ghost commented 3 years ago

This happens on FreeBSD as well. My typescript

This happens on FreeBSD as well. [My typescript](https://mirror.git.trinitydesktop.org/gitea/attachments/32fab0e1-8da0-46dc-977d-c83be7c77cb2)
SlavekB commented 3 years ago
Owner

I'm getting this error for a 14.0.x tdegraphics build with poppler 21.09.0

DateInfo.h line 31 changed in poppler 21.08.0 from this 21.07.0 source [same as 21.06.1]

bool POPPLER_PRIVATE_EXPORT parseDateString(const char *string, int *year, int *month, int *day, int *hour, int *minute, int *second, char *tz, int *tzHour, int *tzMinute);

I don't have a 21.07.0 package to test the build, but tdegraphics builds ok with poppler 21.06.1

If it's any help, this is the culpritcommit

@Ray-V, thank you for accurate information, patch is ready…

> I'm getting this error for a 14.0.x tdegraphics build with poppler 21.09.0 > > DateInfo.h line 31 changed in poppler 21.08.0 from this 21.07.0 source [same as 21.06.1] > ``` > bool POPPLER_PRIVATE_EXPORT parseDateString(const char *string, int *year, int *month, int *day, int *hour, int *minute, int *second, char *tz, int *tzHour, int *tzMinute); > ``` > I don't have a 21.07.0 package to test the build, but tdegraphics builds ok with poppler 21.06.1 > > If it's any help, this is the [<strike>culprit</strike>commit](https://cgit.freedesktop.org/poppler/poppler/commit/?id=2636e51212b99359cc940b806d645a9e43c33d74) @Ray-V, thank you for accurate information, patch is ready…
SlavekB referenced this issue from a commit 3 years ago
Add support for Poppler >= 21.08.
SlavekB referenced this issue from a commit 3 years ago
Add support for Poppler >= 21.08.
SlavekB added this to the R14.0.11 release milestone 3 years ago
SlavekB commented 3 years ago
Owner

Resolved by the commits mentioned above.

Resolved by the commits mentioned above.
SlavekB closed this issue 3 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
r14.1.x
master
r14.0.x
v3.5.13-sru
feat/supersedes-deprecated
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.11 release
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdegraphics#34
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes