Print orientation in ksnapshot cannot be selected. #8
Slēgta
MicheleC atvēra pirms 5 gadiem
·
8 komentāri
Notiek ielāde…
Atsaukties uz šo jaunā problēmā
Vēl nav satura.
Dzēst atzaru '%!s(<nil>)'
Atzara dzēšana ir neatgriezeniska, kā arī tā ir NEATGRIEZENISKA. Vai turpināt?
From user ML:
Problem is confirmed.
Hi Michele,
when looking into the code recently, I noticed that the orientation is automatically selected based on the size/ratio of the image snapped. It compares width/height and sets the orientation (see here). So it works more or less as designed.
Do you think it is relevant to keep this open or to fix it?
Looks like the bug is actually about not being given an option to change (for whatever reason) the automatically picked orientation.
I agree with Philippe, the user should be given the choice to select a specific orientation if he wants. Auto selection is a good initial choice, but there should be a way tooverwrite that if wanted.
I think it is the setOrientation() here. But I do not understand why.
Perhaps due to
in kprinter.cpp
That seems the place where the orientation is selected automatically. But we need to find out why the orientation choice is grayed out in the printer dialog. If we can enable that again, then the user should be able to select a different orientation.
It is set in
and then it uses the printer to get the sizes and scale if needed
So the code is optimizing the image for printing, but after this the user can not change.
I think if we remove the automatic orientation, it would work.
I will test and post result later.
Commenting out the following and the orientation can be set manually
I tested now the default "Portrait" and then with "Landscape". It seems OK.
It also scales the image properly.
I will create PR.
Fixed by PR #54