Remove accidentally added "Qt" prefix from strings. #16

Merged
SlavekB merged 1 commits from branding/qt_to_tqt into master 2 years ago
Chris commented 2 years ago
Collaborator

Don't need any translation. Translations related to that are more or less bad anyway. I don't see a real reason that this "Qt" is included within a translation spring anway, but it's another topic. Maybe at some point someone should review that. From what I have read, the application doesn't work with recent povray anyway. See TDE/tdegraphics#2.

From what Slavek pointed out, I have seen the translations are fine then and preserving them with some commit would make sense again, so I added the label.

Translation files updated in TDE/tde-i18n#20.

Signed-off-by: Chris xchrisx@uber.space

Don't need any translation. Translations related to that are more or less bad anyway. I don't see a real reason that this "Qt" is included within a translation spring anway, but it's another topic. Maybe at some point someone should review that. From what I have read, the application doesn't work with recent povray anyway. See TDE/tdegraphics#2. From what Slavek pointed out, I have seen the translations are fine then and preserving them with some commit would make sense again, so I added the label. Translation files updated in TDE/tde-i18n#20. Signed-off-by: Chris <xchrisx@uber.space>
SlavekB requested changes 2 years ago
SlavekB left a comment

You have encountered a historical mistake made in a rushed mass rename. Instead of continuing of this mistake, it will be good to fix it.

m_pCylinderType->insertItem( i18n( "2:Qt::Horizontal, Fixed Viewpoint" ) );
m_pCylinderType->insertItem( i18n( "3:Qt::Vertical, Variable Viewpoint" ) );
m_pCylinderType->insertItem( i18n( "4:Qt::Horizontal, Variable Viewpoint" ) );
m_pCylinderType->insertItem( i18n( "1:TQt::Vertical, Fixed Viewpoint" ) );
Poster
Owner

Oops, this is a historical bug caused by commit e69e8b1d09 => in these strings there should be neither of these – neither Qt:: nor TQt::.

So the correct fix is not to replace Qt:: with TQt::, but to remove these stray Qt:: prefixes.

Oops, this is a historical bug caused by commit e69e8b1d09 => in these strings there should be neither of these – neither `Qt::` nor `TQt::`. So the correct fix is not to replace `Qt::` with `TQt::`, but to remove these stray `Qt::` prefixes.
Chris commented 2 years ago
Poster
Collaborator

Wonderful. Like I pointed out above, that is a solution I like much more than preserve it the way it is. For me there were no reasons to show that to users in the GUI. I will rework that.

Wonderful. Like I pointed out above, that is a solution I like much more than preserve it the way it is. For me there were no reasons to show that to users in the GUI. I will rework that.
Chris changed title from Replace Qt branding with TQt ones. to Remove accidentally added "Qt" prefix from strings. 2 years ago
Chris added the
PR/update-trans
label 2 years ago
SlavekB approved these changes 2 years ago
SlavekB left a comment

Well done, the updated status looks good.

Chris removed the
PR/update-trans
label 2 years ago
Owner

I apologize, but only now I realized that there was a space after the colon between the number and the text. It certainly would look better. Please can you make this adjustment?

I apologize, but only now I realized that there was a space after the colon between the number and the text. It certainly would look better. Please can you make this adjustment?
Poster
Collaborator

Sure. Yes, to be honest, I realized that too in translations. But was not quite sure, what of both is the right way and I wanted to review that later. I haven't installed kpovmodeler at my system at the moment.

Sure. Yes, to be honest, I realized that too in translations. But was not quite sure, what of both is the right way and I wanted to review that later. I haven't installed kpovmodeler at my system at the moment.
Poster
Collaborator

Done. See translation too.

Done. See translation too.
SlavekB closed this pull request 2 years ago
SlavekB deleted branch branding/qt_to_tqt 2 years ago
SlavekB added this to the R14.0.7 release milestone 2 years ago
The pull request has been merged as 818d71c9f0.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.