Delete kamera pics, not needed anymore. #21

Merged
MicheleC merged 1 commits from fix/camera into master 2 years ago
Chris commented 2 years ago
Collaborator

Relates to TDE/tdelibs#58.

Signed-off-by: Chris xchrisx@uber.space

Relates to https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/58. Signed-off-by: Chris <xchrisx@uber.space>
Owner

camera_test (despite the name) is used in the code, so we should not remove that picture. Or alternatively replace that with a different icon since it seems to be a TDE only icon.

camera_test (despite the name) is used in the code, so we should not remove that picture. Or alternatively replace that with a different icon since it seems to be a TDE only icon.
Poster
Collaborator

@MicheleC: Good point. Just had some thinking about later, but wasn't exactly sure about. The proper way is to adjust the code to use the already existing (and in fact exactly same) icon here. So I will do that, we don't have to preserve that for nothing. 👍

@MicheleC: Good point. Just had some thinking about later, but wasn't exactly sure about. The proper way is to adjust the code to use the already existing (and in fact exactly same) icon here. So I will do that, we don't have to preserve that for nothing. :+1:
Owner

Because there are other icons of similar names next to them – camera_remove, camera_configure, camera_summary, …I think camera_test could stay in place.

Because there are other icons of similar names next to them – camera_remove, camera_configure, camera_summary, …I think camera_test could stay in place.
Poster
Collaborator

Good point. But otherwise, we should look what camera_remove is about. Because camera_test was in fact just "action-add" and if camera_remove is just "action-remove" and camera_configure is just "configure", we should maybe better adopt what is possible to use the already existing, generic icons? This way icon themes would be more compatible, because of having proper, already in common places used icons. I have not looked more into that. For "summary" there is also some generic icon. What do you think about that, @SlavekB?

EDIT: That makes much more sense, if they are really (like test) all the same icons as the generic ones. There isn't any generic icon for test, but that is some problem for more parts of TDE. So maybe I will review that application on my machine and maybe just using the camera icon for test (like it is done for kcmscreensaver for the test screensaver button) is much more logical than using some "add" icon.

Good point. But otherwise, we should look what camera_remove is about. Because camera_test was in fact just "action-add" and if camera_remove is just "action-remove" and camera_configure is just "configure", we should maybe better adopt what is possible to use the already existing, generic icons? This way icon themes would be more compatible, because of having proper, already in common places used icons. I have not looked more into that. For "summary" there is also some generic icon. What do you think about that, @SlavekB? EDIT: That makes much more sense, if they are really (like *test*) all the same icons as the generic ones. There isn't any generic icon for test, but that is some problem for more parts of TDE. So maybe I will review that application on my machine and maybe just using the camera icon for test (like it is done for kcmscreensaver for the test screensaver button) is much more logical than using some "add" icon.
Owner

@SlavekB I can't see any camera_remove or camera_summary icons in my system and in tde src code. Where are they?

camera_test seems to be a one off. @Chris the icon is the same as action-button_ok, not action-add. We can simply remove the icon and change the code to use action-button_ok

@SlavekB I can't see any camera_remove or camera_summary icons in my system and in tde src code. Where are they? camera_test seems to be a one off. @Chris the icon is the same as action-button_ok, not action-add. We can simply remove the icon and change the code to use action-button_ok
Owner

Ah, sorry, I saw the file names listed in the code and therefore I assumed they were present. Now I see that these files don't exist.

Ah, sorry, I saw the file names listed in the code and therefore I assumed they were present. Now I see that these files don't exist.
Owner

@SlavekB those refer to names of the actions, not the icons. Only the camera_test refers to both icon and action and as said we can replace it with action-button_ok.

@SlavekB those refer to names of the actions, not the icons. Only the camera_test refers to both icon and action and as said we can replace it with action-button_ok.
Owner

I have replace the usage of camera_test icon with button_ok. We can now test tdelibs#58 and this PR and if all good merge them. Changes in tde-packaging for debian are required.

I have replace the usage of camera_test icon with button_ok. We can now test tdelibs#58 and this PR and if all good merge them. Changes in tde-packaging for debian are required.
MicheleC closed this pull request 2 years ago
MicheleC deleted branch fix/camera 2 years ago
MicheleC added this to the R14.0.8 release milestone 2 years ago
Poster
Collaborator

@MicheleC: Sorry for not giving enough attention to that the last days. I just got sick the last two days and have feeled not very good. Before, I wanted to bring that Gentoo overlay porting to an end. I havent's exactly looked if it was button-ok, or button-add, it was just from my memory. Surely I would have used the right icon. But good you did finish that now. 😄

@MicheleC: Sorry for not giving enough attention to that the last days. I just got sick the last two days and have feeled not very good. Before, I wanted to bring that Gentoo overlay porting to an end. I havent's exactly looked if it was button-ok, or button-add, it was just from my memory. Surely I would have used the right icon. But good you did finish that now. :smile:
Owner

no worries Chris, thanks for the excellent clean up work you are doing 😄

no worries Chris, thanks for the excellent clean up work you are doing :smile:
The pull request has been merged as f8eca932ce.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.