kpovmodeler not working with povray 3.7 #2

A small fix to make it work with povray3.7

https://bugs.trinitydesktop.org/show_bug.cgi?id=2765

Povray 3.7 does not allow radiosity? Or is it necessary to use other option?

In any case, this patch needs further work.

AFAIR this option is gone

http://www.povray.org/documentation/3.7.0/r3_2.html#r3_2_8_8

as I mentioned in the original bug a lot needs to be reworked, but the purpose of this patch is to make it at least rendering the model, as otherwise it renders the software mostly useless.

regards

Because it is no longer necessary to deal with compatibility with older versions of povray, so there is no need to leave the code.

Looks ok to me. Will wait for final approval from Slavek since he has followed this from the beginning.

It seems insufficient for me. My idea is to advance and remove the Radiosity checkbox from the GUI and the corresponding code. Now there is in the GUI checkbox that has no effect at all, which seems confusing.

There is indeed extra code related to radiosity, I also noticed this morning. The key point is to make sure we remove what is no longer required and whether to do it in this PR or as a separate one, while using this PR only to avoid setting unused (unsupported?? - I don't know) parameters anymore.

Sorry, I never knew there is option for radiosity in the GUI.

Sorry, I never knew there is option for radiosity in the GUI.

I think the respective checkbox is here: pmrendermodesdialog.cpp:350. At the same time, there will be unnecessary methods setRadiosity(...), radiosity() and variable m_radiosity.

Sorry, I never knew there is option for radiosity in the GUI.

I think the respective checkbox is here: pmrendermodesdialog.cpp:350. At the same time, there will be unnecessary methods setRadiosity(...), radiosity() and variable m_radiosity.

yes, obviously there is more work to do. I will have a look, update the code and request review again.
I'll change this to WIP

It looks good, I propose one editing regarding modes 9, 10 and 11.
See comment below.

I also think c_qualityToIndex needs to be updated accordingly and I hope the last change does this correctly. So if OK, I will squash the commits.

I think this last commit is also necessary. I do not understand why it would return numQuality-1

It looks good. Everything seems to me okay.

Please check and clarify the comment below.

@MicheleC thank you, I have overlooked this.
Now fixed this and squashed into one commit.

Looks good now.

@MicheleC thank you, I have overlooked this.
Now fixed this and squashed into one commit.

no worries 😄

Thanks, now all seems good.

 //    if( m_radiosity )
 //       cl.append( TQString( "+QR" ) );
 //    else
 //       cl.append( TQString( "-QR" ) );

    I18N_NOOP( "9: Compute media" ),
    I18N_NOOP( "10: Compute radiosity but no media" ),
    I18N_NOOP( "11: Compute radiosity and media" )
    I18N_NOOP( "9: Compute media" )

       index = 0;
    if( index >= numQuality )
       index = numQuality - 1;
    if( index > numQuality )

kpovmodeler not working with povray 3.7 #2

Gözden Geçirenler