KPDF: Some fixes for cover page mode #30

Merged
MicheleC merged 1 commits from feat/kpdf-coverpage-fixes into master 9 months ago
blu.256 commented 9 months ago
Collaborator
  • 1-page shift is now taken into account for size pages.
    Before this change, the last page of a document with an even count of
    pages would have zero height and be displayed 'floating' over the page
    above it.

  • Improved code readability by using a variable to store the result of
    the cover page mode check.

Signed-off-by: Mavridis Philippe mavridisf@gmail.com

* 1-page shift is now taken into account for size pages. Before this change, the last page of a document with an even count of pages would have zero height and be displayed 'floating' over the page above it. * Improved code readability by using a variable to store the result of the cover page mode check. Signed-off-by: Mavridis Philippe <mavridisf@gmail.com>
blu.256 added 1 commit 9 months ago
ad14876fd1
Some fixes for cover page mode
blu.256 changed title from Some fixes for cover page mode to KPDF: Some fixes for cover page mode 9 months ago
SlavekB reviewed 9 months ago
SlavekB left a comment

It looks good, however, there is one place where there is possible minor adjustment.

// so we can place widgets 'centered in virtual cells'.
int nCols = KpdfSettings::viewColumns(),
nRows = (int)ceil( (float)pageCount / (float)nCols ),
int pageShift = ( KpdfSettings::viewColumns() == 2 && KpdfSettings::viewCoverPage() ) ? 1 : 0,
Poster
Owner

It looks like there is also a place where the coverPageMode variable could be used.

It looks like there is also a place where the `coverPageMode` variable could be used.
Poster
Collaborator

Yes indeed, just changed it.

Yes indeed, just changed it.
SlavekB marked this conversation as resolved
blu.256 added 1 commit 9 months ago
4fc5ba54be
pageShift: use coverPageMode variable.
Owner

Looks good Philippe. Could you squash your commits into one before we merge?

Looks good Philippe. Could you squash your commits into one before we merge?
Poster
Collaborator

Yes, of course. Give me a moment

Yes, of course. Give me a moment
blu.256 force-pushed feat/kpdf-coverpage-fixes from 4fc5ba54be to 08380de42c 9 months ago
Poster
Collaborator

Done!

Done!
MicheleC merged commit 08380de42c into master 9 months ago
MicheleC deleted branch feat/kpdf-coverpage-fixes 9 months ago
Owner

Thanks!

Thanks!
MicheleC added this to the R14.0.10 release milestone 9 months ago
The pull request has been merged as 08380de42c.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.