TDE
/
tdegraphics
8
0
Fork 0
Code Issues 9 Pull Requests 1 Releases Wiki Activity
Labels Milestones

Add a CMake build option WITH_ALL_OPTIONS disabled by default #38

Merged
SlavekB merged 1 commits from feat/with_all_options into master 2 years ago
Conversation 4 Commits 1 Files Changed 1
obache commented 2 years ago
Collaborator

Same as other modules

Same as other modules
obache added 1 commit 2 years ago
obache force-pushed feat/with_all_options from 2d144fe39d to bbecf5bb84 2 years ago
SlavekB approved these changes 2 years ago
SlavekB left a comment
Owner

Great – exactly the same idea I had during work on ArchLinux packaging at the time of finalization R14.0.11, but it was not a good time for such changes. Now is the time!

Great – exactly the same idea I had during work on ArchLinux packaging at the time of finalization R14.0.11, but it was not a good time for such changes. Now is the time!
SlavekB merged commit bbecf5bb84 into master 2 years ago
SlavekB deleted branch feat/with_all_options 2 years ago
SlavekB added this to the R14.0.12 release milestone 2 years ago
SlavekB commented 2 years ago
Owner

Now I was looking that t1lib seem to be abandoned and not maintained. I suggest to change the default value to OFF for all cases. Any objections?

Now I was looking that [t1lib](https://www.t1lib.org/) seem to be abandoned and not maintained. I suggest to change the default value to `OFF` for all cases. Any objections?
MicheleC commented 2 years ago
Owner

Now I was looking that t1lib seem to be abandoned and not maintained. I suggest to change the default value to OFF for all cases. Any objections?

No objection. But if t1lib is abandoned, does it still make sense to support it?

> Now I was looking that [t1lib](https://www.t1lib.org/) seem to be abandoned and not maintained. I suggest to change the default value to `OFF` for all cases. Any objections? No objection. But if t1lib is abandoned, does it still make sense to support it?
SlavekB commented 2 years ago
Owner

Now I was looking that t1lib seem to be abandoned and not maintained. I suggest to change the default value to OFF for all cases. Any objections?

No objection. But if t1lib is abandoned, does it still make sense to support it?

Yes, certainly, we can consider OFF for stable branch and removal for the master. DEB packages are built without the t1lib support for a long time, so no change occurs here.

> > Now I was looking that [t1lib](https://www.t1lib.org/) seem to be abandoned and not maintained. I suggest to change the default value to `OFF` for all cases. Any objections? > > No objection. But if t1lib is abandoned, does it still make sense to support it? Yes, certainly, we can consider OFF for stable branch and removal for the master. DEB packages are built without the t1lib support for a long time, so no change occurs here.
MicheleC commented 2 years ago
Owner

Yes, certainly, we can consider OFF for stable branch and removal for the master. DEB packages are built without the t1lib support for a long time, so no change occurs here.

Sounds perfect!! Let's do it.

> Yes, certainly, we can consider OFF for stable branch and removal for the master. DEB packages are built without the t1lib support for a long time, so no change occurs here. Sounds perfect!! Let's do it.

Reviewers

SlavekB approved these changes 2 years ago
The pull request has been merged as bbecf5bb84.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.12 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdegraphics#38
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/with_all_options'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes