TDE
/
tdegraphics
8
0
Fork 0
Code Issues 9 Pull Requests 1 Releases Wiki Activity
Labels Milestones

WIP:Supersedes deprecated function calls #43

Draft
obache wants to merge 1 commits from feat/supersedes-deprecated into master
Conversation 3 Commits 1 Files Changed 7
obache commented 2 years ago
Collaborator

No reason to use TDE core functions marked as DEPRECATED in TDE core modules.

No reason to use TDE core functions marked as DEPRECATED in TDE core modules.
obache added 1 commit 2 years ago
5e8185513d Supersedes deprecated function calls
obache commented 2 years ago
Poster
Collaborator

setButtonOKText and setButtonCancelText` usage might be wrong originally.
It seems mismatching "text", "tooltip" and "whatsthis" combination.

`setButtonOKText` and setButtonCancelText` usage might be wrong originally. It seems mismatching "text", "tooltip" and "whatsthis" combination.
MicheleC commented 2 years ago
Owner

Hi Obata-san, I take this is still WIP since you have mark it as such in the title. Correct?

Hi Obata-san, I take this is still WIP since you have mark it as such in the title. Correct?
obache commented 2 years ago
Poster
Collaborator

kolourpaint/kptool.cpp:
TODO about ALT should be resolved, but not sure.

kpovmodeler/pmerrordialog.cpp:
OK butttun text still "OK", but "WhatsThis" is "When clicking Proceed", mismatch?
Cancel button, why "ToolTip" is prefixed with "&"?
Such question point is originally exists, but?

"setButtonOK()" will not update "WhatsThis", may different result.
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/src/branch/master/tdeui/kpushbutton.cpp#L134

kpovmodeler/pmpovraywidget.cpp:
"(TQWidget*)nullptr" is good here?

kolourpaint/kptool.cpp: TODO about ALT should be resolved, but not sure. kpovmodeler/pmerrordialog.cpp: OK butttun text still "OK", but "WhatsThis" is "When clicking Proceed", mismatch? Cancel button, why "ToolTip" is prefixed with "&"? Such question point is originally exists, but? "setButtonOK()" will not update "WhatsThis", may different result. https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/src/branch/master/tdeui/kpushbutton.cpp#L134 kpovmodeler/pmpovraywidget.cpp: "(TQWidget*)nullptr" is good here?
This pull request has changes conflicting with the target branch.
kmrml/kmrml/lib/mrml_utils.cpp
kmrml/kmrml/loader.cpp
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdegraphics#43
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/supersedes-deprecated'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes