Here is a bug report from cppcheck:
[ftp.cc:1269]: (style) A pointer can not be negative so it is either pointless or an error to check if it is.
An other one from clang-5.0.2
ordered comparison between pointer and zero ('const char *' and 'int')
if(ftpResponse(-1) <= 0 || (m_iRespType != 2) )
From what I read here and there, a cast to a void pointer can be done.
if(ftpResponse(-1) <= (void*) 0 || (m_iRespType != 2) )
It builds fine, but does the software work as intended?
I’ve noticed that gcc-4.8.5 and clang-3.0 does build “as is” without complaining.
I stepped upon this while converting to cmake since I use clang-5.0.2 for the building.
Because ftpResponse returns char*, I think that in this case, the purpose is to verify if null has been returned. I would therefore expect the following adjustment:
if( (ftpResponse(-1) == null) || (m_iRespType != 2) )
“void” is by definition a null type, so it makes no sense to use order comparison on that, e.g. <= used on a void variable is pretty much a mistake. I believe the best solution is as in tdelibs:
if(!ftpResponse(-1) || (m_iRespType != 2) )
It seems there is quite a bit of duplication between
Resolved - used solution identical to tdelibs.
No due date set.
This issue currently doesn't have any dependencies.
Deleting a branch is permanent. It CANNOT be undone. Continue?