#2 conversion to cmake building system

Merged
SlavekB merged 3 commits from feat/cmakeConv into master 7 months ago
cethyel commented 7 months ago
There is no content yet.
SlavekB commented 7 months ago
Owner

I think that would be helpful in CMake conversions always define BUILD_ALL and WITH_ALL_OPTIONS to have the same standard across all modules.

Do you want to make an ammend of the previous commit, or should I push a separate commit to add these variables?

I think that would be helpful in CMake conversions always define `BUILD_ALL` and `WITH_ALL_OPTIONS` to have the same standard across all modules. Do you want to make an ammend of the previous commit, or should I push a separate commit to add these variables?
cethyel commented 7 months ago
Poster

Consistency is nice, I like that!

Since there’s no need for options beside gcc visibility I went for the simplest.

If you have the time this evening, please commit, otherwise, I’ll do It tomorrow. @+

Consistency is nice, I like that! Since there's no need for options beside gcc visibility I went for the simplest. If you have the time this evening, please commit, otherwise, I'll do It tomorrow. @+
SlavekB commented 7 months ago
Owner

The TIME_WITH_SYS_TIME test in automake verifies whether time.h can be included together with sys/time.h. That’s why I adjusted the cmake test to the same way.

Furthermore, I added a test of the existence of the strtoll function.

The TIME_WITH_SYS_TIME test in automake verifies whether `time.h` can be included together with `sys/time.h`. That's why I adjusted the cmake test to the same way. Furthermore, I added a test of the existence of the `strtoll` function.
SlavekB commented 7 months ago
Owner

Merged and pushed upstream.

Merged and pushed upstream.
SlavekB deleted branch feat/cmakeConv 7 months ago
SlavekB added this to the R14.0.6 release milestone 7 months ago
cethyel commented 7 months ago
Poster

Including time.h and sys/time.h is convenient, I didn’t know that could be done, nice!

Regarding testing functions, do we already have a test for each functions that are provided by the c++ lib or the c lib?

Including time.h and sys/time.h is convenient, I didn't know that could be done, nice! Regarding testing functions, do we already have a test for each functions that are provided by the c++ lib or the c lib?
SlavekB commented 7 months ago
Owner

Because for some reason HAVE_STRTOLL was used in the code, it was strange to define it in config.h without performing the test. I could either spend time researching whether this definition is still meaningful or add the test. I used a simpler solution :smile:

Because for some reason `HAVE_STRTOLL` was used in the code, it was strange to define it in `config.h` without performing the test. I could either spend time researching whether this definition is still meaningful or add the test. I used a simpler solution :smile:
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.