I think that would be helpful in CMake conversions always define BUILD_ALL and WITH_ALL_OPTIONS to have the same standard across all modules.
Do you want to make an ammend of the previous commit, or should I push a separate commit to add these variables?
Consistency is nice, I like that!
Since there’s no need for options beside gcc visibility I went for the simplest.
If you have the time this evening, please commit, otherwise, I’ll do It tomorrow.
The TIME_WITH_SYS_TIME test in automake verifies whether time.h can be included together with sys/time.h. That’s why I adjusted the cmake test to the same way.
Furthermore, I added a test of the existence of the strtoll function.
Merged and pushed upstream.
Including time.h and sys/time.h is convenient, I didn’t know that could be done, nice!
Regarding testing functions, do we already have a test for each functions that are provided by the c++ lib or the c lib?
Because for some reason HAVE_STRTOLL was used in the code, it was strange to define it in config.h without performing the test. I could either spend time researching whether this definition is still meaningful or add the test. I used a simpler solution :smile:
No due date set.
This pull request currently doesn't have any dependencies.
Deleting a branch is permanent. It CANNOT be undone. Continue?