conversion to cmake building system #2

Sloučený
SlavekB sloučil 1 commity z větve feat/cmakeConv do větve master před před 6 roky
Ghost okomentoval před 6 roky
Není zde žádný obsah.
SlavekB okomentoval před 6 roky
Vlastník

I think that would be helpful in CMake conversions always define BUILD_ALL and WITH_ALL_OPTIONS to have the same standard across all modules.

Do you want to make an ammend of the previous commit, or should I push a separate commit to add these variables?

I think that would be helpful in CMake conversions always define `BUILD_ALL` and `WITH_ALL_OPTIONS` to have the same standard across all modules. Do you want to make an ammend of the previous commit, or should I push a separate commit to add these variables?
Ghost okomentoval před 6 roky
Autor

Consistency is nice, I like that!

Since there's no need for options beside gcc visibility I went for the simplest.

If you have the time this evening, please commit, otherwise, I'll do It tomorrow.
@+

Consistency is nice, I like that! Since there's no need for options beside gcc visibility I went for the simplest. If you have the time this evening, please commit, otherwise, I'll do It tomorrow. @+
SlavekB okomentoval před 6 roky
Vlastník

The TIME_WITH_SYS_TIME test in automake verifies whether time.h can be included together with sys/time.h. That's why I adjusted the cmake test to the same way.

Furthermore, I added a test of the existence of the strtoll function.

The TIME_WITH_SYS_TIME test in automake verifies whether `time.h` can be included together with `sys/time.h`. That's why I adjusted the cmake test to the same way. Furthermore, I added a test of the existence of the `strtoll` function.
SlavekB uzavřel/a tento požadavek na natažení před 6 roky
SlavekB okomentoval před 6 roky
Vlastník

Merged and pushed upstream.

Merged and pushed upstream.
SlavekB odstranil/a větev feat/cmakeConv před 6 roky
SlavekB přidal/a toto do milníku R14.0.6 release před 6 roky
Ghost okomentoval před 6 roky
Autor

Including time.h and sys/time.h is convenient, I didn't know that could be done, nice!

Regarding testing functions, do we already have a test for each functions that are provided by the c++ lib or the c lib?

Including time.h and sys/time.h is convenient, I didn't know that could be done, nice! Regarding testing functions, do we already have a test for each functions that are provided by the c++ lib or the c lib?
SlavekB okomentoval před 6 roky
Vlastník

Because for some reason HAVE_STRTOLL was used in the code, it was strange to define it in config.h without performing the test. I could either spend time researching whether this definition is still meaningful or add the test. I used a simpler solution 😄

Because for some reason `HAVE_STRTOLL` was used in the code, it was strange to define it in `config.h` without performing the test. I could either spend time researching whether this definition is still meaningful or add the test. I used a simpler solution :smile:
Požadavek na natažení byl sloučen jako ac46856010.
Přihlaste se pro zapojení do konverzace.
Žádní posuzovatelé
Bez milníku
Bez zpracovatelů
2 účastníků
Oznámení
Termín dokončení

Žádný termín dokončení.

Závislosti

Nejsou nastaveny žádné závislosti.

Reference: TDE/tdeio-ftps#2
Načítá se…
Není zde žádný obsah.