conversion to cmake building system #2

Sammanfogat
SlavekB sammanfogade 1 incheckningar från feat/cmakeConv in i master 6 år sedan
Ghost kommenterad 6 år sedan
Det finns inget innehåll än.
SlavekB kommenterad 6 år sedan
Ägare

I think that would be helpful in CMake conversions always define BUILD_ALL and WITH_ALL_OPTIONS to have the same standard across all modules.

Do you want to make an ammend of the previous commit, or should I push a separate commit to add these variables?

I think that would be helpful in CMake conversions always define `BUILD_ALL` and `WITH_ALL_OPTIONS` to have the same standard across all modules. Do you want to make an ammend of the previous commit, or should I push a separate commit to add these variables?
Ghost kommenterad 6 år sedan
Skapare

Consistency is nice, I like that!

Since there's no need for options beside gcc visibility I went for the simplest.

If you have the time this evening, please commit, otherwise, I'll do It tomorrow.
@+

Consistency is nice, I like that! Since there's no need for options beside gcc visibility I went for the simplest. If you have the time this evening, please commit, otherwise, I'll do It tomorrow. @+
SlavekB kommenterad 6 år sedan
Ägare

The TIME_WITH_SYS_TIME test in automake verifies whether time.h can be included together with sys/time.h. That's why I adjusted the cmake test to the same way.

Furthermore, I added a test of the existence of the strtoll function.

The TIME_WITH_SYS_TIME test in automake verifies whether `time.h` can be included together with `sys/time.h`. That's why I adjusted the cmake test to the same way. Furthermore, I added a test of the existence of the `strtoll` function.
SlavekB closed this pull request 6 år sedan
SlavekB kommenterad 6 år sedan
Ägare

Merged and pushed upstream.

Merged and pushed upstream.
SlavekB tog bort grenen feat/cmakeConv 6 år sedan
SlavekB lade till denna till milstolpe R14.0.6 release 6 år sedan
Ghost kommenterad 6 år sedan
Skapare

Including time.h and sys/time.h is convenient, I didn't know that could be done, nice!

Regarding testing functions, do we already have a test for each functions that are provided by the c++ lib or the c lib?

Including time.h and sys/time.h is convenient, I didn't know that could be done, nice! Regarding testing functions, do we already have a test for each functions that are provided by the c++ lib or the c lib?
SlavekB kommenterad 6 år sedan
Ägare

Because for some reason HAVE_STRTOLL was used in the code, it was strange to define it in config.h without performing the test. I could either spend time researching whether this definition is still meaningful or add the test. I used a simpler solution 😄

Because for some reason `HAVE_STRTOLL` was used in the code, it was strange to define it in `config.h` without performing the test. I could either spend time researching whether this definition is still meaningful or add the test. I used a simpler solution :smile:
Pull-förfrågan har sammanfogats som ac46856010.
Logga in för att delta i denna konversation.
Inga granskare
Ingen Milsten
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: TDE/tdeio-ftps#2
Laddar…
Det finns inget innehåll än.