conversion to cmake building system #2

已合併
SlavekB 將 1 次提交從 feat/cmakeConv 合併至 master 6 年前
Ghost 已留言 6 年前
尚未有任何內容
擁有者

I think that would be helpful in CMake conversions always define BUILD_ALL and WITH_ALL_OPTIONS to have the same standard across all modules.

Do you want to make an ammend of the previous commit, or should I push a separate commit to add these variables?

I think that would be helpful in CMake conversions always define `BUILD_ALL` and `WITH_ALL_OPTIONS` to have the same standard across all modules. Do you want to make an ammend of the previous commit, or should I push a separate commit to add these variables?
Ghost 已留言 6 年前
發布者

Consistency is nice, I like that!

Since there's no need for options beside gcc visibility I went for the simplest.

If you have the time this evening, please commit, otherwise, I'll do It tomorrow.
@+

Consistency is nice, I like that! Since there's no need for options beside gcc visibility I went for the simplest. If you have the time this evening, please commit, otherwise, I'll do It tomorrow. @+
擁有者

The TIME_WITH_SYS_TIME test in automake verifies whether time.h can be included together with sys/time.h. That's why I adjusted the cmake test to the same way.

Furthermore, I added a test of the existence of the strtoll function.

The TIME_WITH_SYS_TIME test in automake verifies whether `time.h` can be included together with `sys/time.h`. That's why I adjusted the cmake test to the same way. Furthermore, I added a test of the existence of the `strtoll` function.
SlavekB 關閉了這個合併請求 6 年前
擁有者

Merged and pushed upstream.

Merged and pushed upstream.
SlavekB 刪除分支 feat/cmakeConv 6 年前
SlavekB 新增到 R14.0.6 release 里程碑 6 年前
Ghost 已留言 6 年前
發布者

Including time.h and sys/time.h is convenient, I didn't know that could be done, nice!

Regarding testing functions, do we already have a test for each functions that are provided by the c++ lib or the c lib?

Including time.h and sys/time.h is convenient, I didn't know that could be done, nice! Regarding testing functions, do we already have a test for each functions that are provided by the c++ lib or the c lib?
擁有者

Because for some reason HAVE_STRTOLL was used in the code, it was strange to define it in config.h without performing the test. I could either spend time researching whether this definition is still meaningful or add the test. I used a simpler solution 😄

Because for some reason `HAVE_STRTOLL` was used in the code, it was strange to define it in `config.h` without performing the test. I could either spend time researching whether this definition is still meaningful or add the test. I used a simpler solution :smile:
此合併請求已被合併為 ac46856010
登入 才能加入這對話。
沒有審核者
未選擇里程碑
沒有負責人
2 參與者
通知
截止日期

未設定截止日期。

先決條件

未設定先決條件。

參考: TDE/tdeio-ftps#2
載入中…
尚未有任何內容