cmake conversion #1

Fusionado
SlavekB fusionados 1 commits de feat/cmakeConv en master hace 5 años
Ghost comentado hace 5 años
Aún no existe contenido.
SlavekB revisado hace 5 años
SlavekB dejó un comentario
Propietario

The code looks good, but the search sword includes and the library following the pkg_search_module seems unnecessary.

I tested the code without this search and with the modifications mentioned below in the comments and everything was fine. Please test on your machine and make the adjustments according to the result.

The code looks good, but the search sword includes and the library following the `pkg_search_module` seems unnecessary. I tested the code without this search and with the modifications mentioned below in the comments and everything was fine. Please test on your machine and make the adjustments according to the result.
)
set( LIBSWORD_LIBRARIES ${LIBSWORD_LIBRARY} )
set( LIBSWORD_INCLUDE_DIRS ${LIBSWORD_INCLUDE_DIR} )
Propietario

Why there is a separate search for LIBSWORD_INCLUDE_DIR and LIBSWORD_LIBRARY when LIBSWORD_INCLUDE_DIRS and LIBSWORD_LIBRARIES are already set by

pkg_search_module (LIBSWORD sword)

?

Why there is a separate search for `LIBSWORD_INCLUDE_DIR` and `LIBSWORD_LIBRARY` when `LIBSWORD_INCLUDE_DIRS` and `LIBSWORD_LIBRARIES` are already set by ``` pkg_search_module (LIBSWORD sword) ``` ?
${CMAKE_CURRENT_SOURCE_DIR}
${TDE_INCLUDE_DIR}
${TQT_INCLUDE_DIRS}
${LIBSWORD_INCLUDE_DIR}
Propietario

Here you can use LIBSWORD_INCLUDE_DIRS, which is defined by pkg_search_module(…)

Here you can use `LIBSWORD_INCLUDE_DIRS`, which is defined by `pkg_search_module(…)`
LINK
tdecore-shared
tdeio-shared
${LIBSWORD_LIBRARY}
Propietario

Here you can use LIBSWORD_LIBRARIES, which is defined by pkg_search_module(…)

Here you can use `LIBSWORD_LIBRARIES`, which is defined by `pkg_search_module(…)`
SlavekB añadió la etiqueta PR/rfc hace 5 años
SlavekB aprobado estos cambios hace 5 años
SlavekB dejó un comentario
Propietario

After the final edits, the code is ready. Thank you for your efforts.

After the final edits, the code is ready. Thank you for your efforts.
SlavekB eliminó la etiqueta PR/rfc hace 5 años
SlavekB cerró este pull request hace 5 años
SlavekB rama eliminada feat/cmakeConv hace 5 años
SlavekB ha añadido esto al hito R14.0.6 release hace 5 años
El Pull Request se ha fusionado como 8a9f67e94a.
Inicie sesión para unirse a esta conversación.
No hay revisores
Sin Milestone
No asignados
2 participantes
Notificaciones
Fecha de vencimiento

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: TDE/tdeio-sword#1
Cargando…
Aún no existe contenido.