cmake conversion #1

Yhdistetty
SlavekB yhdistetty 1 committia lähteestä feat/cmakeConv kohteeseen master 5 vuotta sitten
Sisältöä ei vielä ole.
SlavekB reviewed 5 vuotta sitten
SlavekB jätti kommentin
Omistaja

The code looks good, but the search sword includes and the library following the pkg_search_module seems unnecessary.

I tested the code without this search and with the modifications mentioned below in the comments and everything was fine. Please test on your machine and make the adjustments according to the result.

The code looks good, but the search sword includes and the library following the `pkg_search_module` seems unnecessary. I tested the code without this search and with the modifications mentioned below in the comments and everything was fine. Please test on your machine and make the adjustments according to the result.
)
set( LIBSWORD_LIBRARIES ${LIBSWORD_LIBRARY} )
set( LIBSWORD_INCLUDE_DIRS ${LIBSWORD_INCLUDE_DIR} )
Omistaja

Why there is a separate search for LIBSWORD_INCLUDE_DIR and LIBSWORD_LIBRARY when LIBSWORD_INCLUDE_DIRS and LIBSWORD_LIBRARIES are already set by

pkg_search_module (LIBSWORD sword)

?

Why there is a separate search for `LIBSWORD_INCLUDE_DIR` and `LIBSWORD_LIBRARY` when `LIBSWORD_INCLUDE_DIRS` and `LIBSWORD_LIBRARIES` are already set by ``` pkg_search_module (LIBSWORD sword) ``` ?
${CMAKE_CURRENT_SOURCE_DIR}
${TDE_INCLUDE_DIR}
${TQT_INCLUDE_DIRS}
${LIBSWORD_INCLUDE_DIR}
Omistaja

Here you can use LIBSWORD_INCLUDE_DIRS, which is defined by pkg_search_module(…)

Here you can use `LIBSWORD_INCLUDE_DIRS`, which is defined by `pkg_search_module(…)`
LINK
tdecore-shared
tdeio-shared
${LIBSWORD_LIBRARY}
Omistaja

Here you can use LIBSWORD_LIBRARIES, which is defined by pkg_search_module(…)

Here you can use `LIBSWORD_LIBRARIES`, which is defined by `pkg_search_module(…)`
SlavekB added the PR/rfc label 5 vuotta sitten
SlavekB hyväksyi nämä muutokset 5 vuotta sitten
SlavekB jätti kommentin
Omistaja

After the final edits, the code is ready. Thank you for your efforts.

After the final edits, the code is ready. Thank you for your efforts.
SlavekB removed the PR/rfc label 5 vuotta sitten
SlavekB closed this pull request 5 vuotta sitten
SlavekB poisti haaran feat/cmakeConv 5 vuotta sitten
SlavekB lisäsi tämän merkkipaaluun R14.0.6 release 5 vuotta sitten
The pull request has been merged as 8a9f67e94a.
Sign in to join this conversation.
No reviewers
Ei merkkipaalua
Ei käsittelijää
2 osallistujaa
Ilmoitukset
Määräpäivä

Määräpäivää ei asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Reference: TDE/tdeio-sword#1
Ladataan…
Sisältöä ei vielä ole.