cmake conversion #1

Unito
SlavekB ha unito 1 commit da feat/cmakeConv a master 5 anni fa
Ghost 5 anni fa ha commentato
Non ci sono ancora contenuti.
SlavekB revisionato 5 anni fa
SlavekB lascia un commento
Proprietario

The code looks good, but the search sword includes and the library following the pkg_search_module seems unnecessary.

I tested the code without this search and with the modifications mentioned below in the comments and everything was fine. Please test on your machine and make the adjustments according to the result.

The code looks good, but the search sword includes and the library following the `pkg_search_module` seems unnecessary. I tested the code without this search and with the modifications mentioned below in the comments and everything was fine. Please test on your machine and make the adjustments according to the result.
)
set( LIBSWORD_LIBRARIES ${LIBSWORD_LIBRARY} )
set( LIBSWORD_INCLUDE_DIRS ${LIBSWORD_INCLUDE_DIR} )
SlavekB 5 anni fa ha commentato
Proprietario

Why there is a separate search for LIBSWORD_INCLUDE_DIR and LIBSWORD_LIBRARY when LIBSWORD_INCLUDE_DIRS and LIBSWORD_LIBRARIES are already set by

pkg_search_module (LIBSWORD sword)

?

Why there is a separate search for `LIBSWORD_INCLUDE_DIR` and `LIBSWORD_LIBRARY` when `LIBSWORD_INCLUDE_DIRS` and `LIBSWORD_LIBRARIES` are already set by ``` pkg_search_module (LIBSWORD sword) ``` ?
${CMAKE_CURRENT_SOURCE_DIR}
${TDE_INCLUDE_DIR}
${TQT_INCLUDE_DIRS}
${LIBSWORD_INCLUDE_DIR}
SlavekB 5 anni fa ha commentato
Proprietario

Here you can use LIBSWORD_INCLUDE_DIRS, which is defined by pkg_search_module(…)

Here you can use `LIBSWORD_INCLUDE_DIRS`, which is defined by `pkg_search_module(…)`
LINK
tdecore-shared
tdeio-shared
${LIBSWORD_LIBRARY}
SlavekB 5 anni fa ha commentato
Proprietario

Here you can use LIBSWORD_LIBRARIES, which is defined by pkg_search_module(…)

Here you can use `LIBSWORD_LIBRARIES`, which is defined by `pkg_search_module(…)`
SlavekB ha aggiunto l'etichetta PR/rfc 5 anni fa
SlavekB hanno approvato queste modifiche 5 anni fa
SlavekB lascia un commento
Proprietario

After the final edits, the code is ready. Thank you for your efforts.

After the final edits, the code is ready. Thank you for your efforts.
SlavekB rimosso l'etichetta PR/rfc 5 anni fa
SlavekB chiusa questa pull request 5 anni fa
SlavekB branch feat/cmakeConv eliminato 5 anni fa
SlavekB aggiunta alle pietre miliari R14.0.6 release 5 anni fa
La pull request è stata unita come 8a9f67e94a.
Effettua l'accesso per partecipare alla conversazione.
Nessun revisore
Nessuna milestone
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: TDE/tdeio-sword#1
Caricamento…
Non ci sono ancora contenuti.