cmake conversion #1
Sapludināts
SlavekB
sapludināja 1 revīzijas no feat/cmakeConv uz master pirms 5 gadiem
Nav recenzentu
Nav etiķešu
Nav atbildīgo
2 dalībnieki
Paziņojumi
Izpildes termiņš
Izpildes termiņš nav uzstādīts.
Atkarības
Nav atkarību.
Atsaucas uz: TDE/tdeio-sword#1
Notiek ielāde…
Atsaukties uz šo jaunā problēmā
Vēl nav satura.
Dzēst atzaru 'feat/cmakeConv'
Atzara dzēšana ir neatgriezeniska, kā arī tā ir NEATGRIEZENISKA. Vai turpināt?
The code looks good, but the search sword includes and the library following the
pkg_search_moduleseems unnecessary.I tested the code without this search and with the modifications mentioned below in the comments and everything was fine. Please test on your machine and make the adjustments according to the result.
)set( LIBSWORD_LIBRARIES ${LIBSWORD_LIBRARY} )set( LIBSWORD_INCLUDE_DIRS ${LIBSWORD_INCLUDE_DIR} )Why there is a separate search for
LIBSWORD_INCLUDE_DIRandLIBSWORD_LIBRARYwhenLIBSWORD_INCLUDE_DIRSandLIBSWORD_LIBRARIESare already set by?
${CMAKE_CURRENT_SOURCE_DIR}${TDE_INCLUDE_DIR}${TQT_INCLUDE_DIRS}${LIBSWORD_INCLUDE_DIR}Here you can use
LIBSWORD_INCLUDE_DIRS, which is defined bypkg_search_module(…)LINKtdecore-sharedtdeio-shared${LIBSWORD_LIBRARY}Here you can use
LIBSWORD_LIBRARIES, which is defined bypkg_search_module(…)After the final edits, the code is ready. Thank you for your efforts.
8a9f67e94a.