cmake conversion #1
Samengevoegd
SlavekB
heeft 1 commits samengevoegd van feat/cmakeConv
naar master
5 jaren geleden
Laden…
Verwijs in nieuw issue
Er is nog geen inhoud.
Verwijder branch 'feat/cmakeConv'
Het verwijderen van een branch is permanent. Het KAN NIET ongedaan gemaakt worden. Wil je toch doorgaan?
The code looks good, but the search sword includes and the library following the
pkg_search_module
seems unnecessary.I tested the code without this search and with the modifications mentioned below in the comments and everything was fine. Please test on your machine and make the adjustments according to the result.
)
set( LIBSWORD_LIBRARIES ${LIBSWORD_LIBRARY} )
set( LIBSWORD_INCLUDE_DIRS ${LIBSWORD_INCLUDE_DIR} )
Why there is a separate search for
LIBSWORD_INCLUDE_DIR
andLIBSWORD_LIBRARY
whenLIBSWORD_INCLUDE_DIRS
andLIBSWORD_LIBRARIES
are already set by?
${CMAKE_CURRENT_SOURCE_DIR}
${TDE_INCLUDE_DIR}
${TQT_INCLUDE_DIRS}
${LIBSWORD_INCLUDE_DIR}
Here you can use
LIBSWORD_INCLUDE_DIRS
, which is defined bypkg_search_module(…)
LINK
tdecore-shared
tdeio-shared
${LIBSWORD_LIBRARY}
Here you can use
LIBSWORD_LIBRARIES
, which is defined bypkg_search_module(…)
After the final edits, the code is ready. Thank you for your efforts.
8a9f67e94a
.