Fix missing argments for drive parse filter on lpr #100
Merged
MicheleC
merged 1 commits from feat/fix-lpr-driveparse-filter-args into master 4 years ago
SlavekB
MicheleC
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/fix-lpr-driveparse-filter-args'
Deleting a branch is permanent. It CANNOT be undone. Continue?
It was extended for compressed PPD support, but not refrected to lpr parts.
It looks good.
Looks good but code could be improved.
}int parseApsFile(const char *filename, FILE *output)int parseApsFile(const char *filename, const char *orign, const char *metadata, FILE *output)I would use something like
or
given those two parameters are not used in the function.
I thought so too but just selected a same manner used in other parser functions including
parseCompressedPpdFilein tdeprint/cups/make_driver_db_cups.c, it is the only implementation using such two extra args.}int parseIfhpFile(const char *filename, FILE *output)int parseIfhpFile(const char *filename, const char *orign, const char *metadata, FILE *output)Similar comment here.
Great, it's good to avoid warnings from the compiler. I assume there are no objections to squash commits into one?
15116d8f64into master 4 years agoFixed typo, squashed and merge as discussed.
I'm getting errors from gcc 9.3.0 due to the fact that it's possible to remove the parameter names under C++, but not under C, so the commenting in tdeprint/driverparse.c and tdeprint/lpr/make_driver_db_lpr.c is causing problems but tdeprint/cups/make_driver_db_cups.cpp compiles fine.
@aneejit1 thank you for the warning! Fixed by commit
1b2d3b15.Reviewers
15116d8f64.