KPty: add posix_openpt support and imporve openpty support #108
Merged
SlavekB
merged 2 commits from feat/fix-openpty-conditional
into master
4 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/fix-openpty-conditional'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Add support to open master pseudo terminal device with posix standard
posix_openpt
.Fix
KPty::open
preventing to open slave pseudo ttys twice foropenpty
platforms.Looks good.
@SlavekB do you want to test build in BSD before merging?
It looks good, but I have one question there – see the comment.
_tcsetattr(d->slaveFd, &ttmode);
#ifndef HAVE_OPENPTY
The previous ioctl call to set screen size is conditioned by
#ifdef HAVE_OPENPTY
, while this call is exactly the opposite –#ifndef HAVE_OPENPTY
. It is not clear to me why this is the case. Please, can you explain that to me?Screen size should be already set with
openpty
call inKPty::open
, but forKPty::setPty
case (d->slaveFd == -1), it is unsure howmasterFd
is opened, i.e. howKPty::setPty
is used.Tested on FreeBSD – build is successful.
Ok, it looks ready to merge.
8f7371cddf
into master 4 years agoReviewers
8f7371cddf
.